niklas.ortmann/webprogrammierung
0
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Verbotene Konzepte in JavaScript entfernt #61

Closed
caroline.slt wants to merge 4 commits from Verbotene_JavaScript_Konzepte into dev
pull from: Verbotene_JavaScript_Konzepte
merge into: niklas.ortmann:dev
Conversation 1 Commits 4 Files Changed 7
+35 -16
2 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ef3699d5f5 - Show all commits
content/search-results.php
+34 -16
View File
@@ -123,9 +123,11 @@ $categories = [
</select>
</div>
<button type="submit" class="nav__search-button">
Filter anwenden
</button>
<noscript>
caroline.slt marked this conversation as resolved Outdated
niklas.ortmann commented 2026-07-19 21:18:58 +02:00
Outdated
Review
Copy Link
Copy Source

Alles, was mit noscript eingebunden wird, soll nur dann sichtbar sein, wenn kein js aktiviert ist. Davon abgesehen, warum sollte das ein verbotenes Konzept in js ein???

Alles, was mit noscript eingebunden wird, soll nur dann sichtbar sein, wenn kein js aktiviert ist. Davon abgesehen, warum sollte das ein verbotenes Konzept in js ein???
niklas.ortmann commented 2026-07-19 21:29:25 +02:00
Outdated
Review
Copy Link
Copy Source

Das kann Maximilian auch nicht angemerkt haben, da das heute durch #54 erst hinzukam.

Das kann Maximilian auch nicht angemerkt haben, da das heute durch https://git.gigaworld.ddns.net/niklas.ortmann/webprogrammierung/pulls/54 erst hinzukam.
<button type="submit" class="nav__search-button">
Filter anwenden
</button>
</noscript>
</form>
</aside>
@@ -189,22 +191,38 @@ $categories = [
<option value="50" <?php echo $limit === 50 ? 'selected' : ''; ?>>50</option>
<option value="100" <?php echo $limit === 100 ? 'selected' : ''; ?>>100</option>
caroline.slt marked this conversation as resolved Outdated
niklas.ortmann commented 2026-07-19 21:19:05 +02:00
Outdated
Review
Copy Link
Copy Source

s.o.

s.o.
</select>
<button type="submit"
form="s-res-filter-form"
class="nav__search-button">
Übernehmen
</button>
<noscript><button type="submit" form="s-res-filter-form" class="nav__search-button">Übernehmen</button></noscript>
</div>
<nav class="s-res-page-navigation" aria-label="Seitennavigation">
<?php echo renderNoJsPagination(
$currentPage,
$totalPages,
$query,
$currentSort,
$currentCategory,
$limit
); ?>
<noscript>
<?php echo renderNoJsPagination(
caroline.slt marked this conversation as resolved Outdated
niklas.ortmann commented 2026-07-19 21:19:22 +02:00
Outdated
Review
Copy Link
Copy Source

s.o.

s.o.
$currentPage,
$totalPages,
$query,
$currentSort,
$currentCategory,
$limit
); ?>
</noscript>
<div id="js-page-navigation" style="display: none;">
<button type="button"
class="s-res-page-btn"
id="prev-page-btn">
«
</button>
<span id="dynamic-page-numbers"></span>
<button type="button"
class="s-res-page-btn"
id="next-page-btn">
»
</button>
</div>
</nav>
</div>
index.php
+1
View File
@@ -27,6 +27,7 @@ include_once "php/controller/index-controller.php";
<script src="js/profile.js" defer></script>
<script src="js/editor.js" async></script>
caroline.slt marked this conversation as resolved Outdated
niklas.ortmann commented 2026-07-19 21:20:15 +02:00
Outdated
Review
Copy Link
Copy Source

warum entfernst du das ?!?!

warum entfernst du das ?!?!
<script src="js/showCategory.js" async></script>
<script src="js/search.js" async></script>
<title>EduForge</title>