niklas.ortmann/webprogrammierung
0
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Verbotene Konzepte in JavaScript entfernt #61

Closed
caroline.slt wants to merge 4 commits from Verbotene_JavaScript_Konzepte into dev
pull from: Verbotene_JavaScript_Konzepte
merge into: niklas.ortmann:dev
Conversation 1 Commits 4 Files Changed 7
+95 -28
caroline.slt commented 2026-07-19 20:05:37 +02:00
Collaborator
Copy Link
Copy Source
No description provided.
caroline.slt added 1 commit 2026-07-19 20:05:37 +02:00
. d7d121b541
caroline.slt added 1 commit 2026-07-19 20:10:56 +02:00
. 5eca2f162b
caroline.slt added 1 commit 2026-07-19 20:58:59 +02:00
. fedb6f59f5
niklas.ortmann requested changes 2026-07-19 21:20:29 +02:00
content/search-results.php Outdated
@@ -126,3 +126,1 @@
<noscript>
<button type="submit" class="nav__search-button">Filter anwenden</button>
</noscript>
<button type="submit" class="nav__search-button">
niklas.ortmann commented 2026-07-19 21:18:58 +02:00
Owner
Copy Link
Copy Source

Alles, was mit noscript eingebunden wird, soll nur dann sichtbar sein, wenn kein js aktiviert ist. Davon abgesehen, warum sollte das ein verbotenes Konzept in js ein???

Alles, was mit noscript eingebunden wird, soll nur dann sichtbar sein, wenn kein js aktiviert ist. Davon abgesehen, warum sollte das ein verbotenes Konzept in js ein???
niklas.ortmann commented 2026-07-19 21:29:25 +02:00
Owner
Copy Link
Copy Source

Das kann Maximilian auch nicht angemerkt haben, da das heute durch #54 erst hinzukam.

Das kann Maximilian auch nicht angemerkt haben, da das heute durch https://git.gigaworld.ddns.net/niklas.ortmann/webprogrammierung/pulls/54 erst hinzukam.
caroline.slt marked this conversation as resolved
content/search-results.php Outdated
@@ -190,3 +190,3 @@
<option value="100" <?php echo $limit === 100 ? 'selected' : ''; ?>>100</option>
</select>
<noscript><button type="submit" form="s-res-filter-form" class="nav__search-button">Übernehmen</button></noscript>
<button type="submit"
niklas.ortmann commented 2026-07-19 21:19:05 +02:00
Owner
Copy Link
Copy Source

s.o.

s.o.
caroline.slt marked this conversation as resolved
content/search-results.php Outdated
@@ -204,3 +200,1 @@
<span id="dynamic-page-numbers"></span>
<button type="button" class="s-res-page-btn" id="next-page-btn">»</button>
</div>
<?php echo renderNoJsPagination(
niklas.ortmann commented 2026-07-19 21:19:22 +02:00
Owner
Copy Link
Copy Source

s.o.

s.o.
caroline.slt marked this conversation as resolved
index.php Outdated
@@ -26,3 +26,3 @@
<script src="js/comments.js" defer></script>
<script src="js/profile.js" defer></script>
<script src="js/editor.js" async></script>
<script src="js/search-results.js" async></script>
niklas.ortmann commented 2026-07-19 21:20:15 +02:00
Owner
Copy Link
Copy Source

warum entfernst du das ?!?!

warum entfernst du das ?!?!
caroline.slt marked this conversation as resolved
caroline.slt added 1 commit 2026-07-19 21:54:49 +02:00
Reviewänderungen ef3699d5f5
niklas.ortmann closed this pull request 2026-07-20 00:10:14 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
niklas.ortmann
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
caroline.slt viratex niklas.ortmann
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: niklas.ortmann/webprogrammierung#61
Delete Branch "Verbotene_JavaScript_Konzepte"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?