Merge remote-tracking branch 'origin/bugs' into bugs

Reviewed-on: #60
Reviewed-by: niklas.ortmann <ortmann.niklas@yahoo.de>

.idea/dataSources.local.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
-  <component name="dataSourceStorageLocal" created-in="IU-261.25134.95">
+  <component name="dataSourceStorageLocal" created-in="IU-253.32098.101">
     <data-source name="articles" uuid="315cb5c9-2b0f-435b-b602-59823b160908">
       <database-info product="SQLite" version="3.51.1" jdbc-version="4.2" driver-name="SQLite JDBC" driver-version="3.51.1.0" dbms="SQLITE" exact-version="3.51.1" exact-driver-version="3.51">
         <identifier-quote-string>&quot;</identifier-quote-string>

content/createArticle.php

@@ -27,6 +27,8 @@ $blocks = array_values($blocks); // sequentielle Indizes 0..n-1 sicherstellen
 -->
 <form method="post" action="php/controller/createArticle-controller.php" id="editor-form" enctype="multipart/form-data" class="article-editor-scope.editor-container article-editor-scope editor-container">
 
+    <?php csrf_field(); ?>
+
     <main class="editor-main">
         <?php include_once "includes/alertMessages.php"?>
 

content/profile.php

@@ -1,5 +1,4 @@
 <?php
-include_once 'php/controller/profile-controller.php';
 
 $user = $user ?? null;
 $isEditMode = (isset($_GET["edit"]) && $_GET["edit"] === "1") || !empty($error);

content/showArticle.php

@@ -5,6 +5,30 @@ $repliesByParent = [];
 $articleObj = null;
 
 include_once 'php/controller/showArticle-controller.php';
+require_once 'php/model/UserManager.php';
+
+$userManager = UserManager::getInstance();
+
+/**
+ * Liefert den vollständigen Namen zu einer gespeicherten E-Mail-Adresse.
+ * Falls kein Benutzer gefunden wird, wird die E-Mail als Ersatz angezeigt.
+ */
+function getCommentAuthorName($email, $userManager)
+{
+    $email = trim($email);
+    $user = $userManager->findUser($email);
+
+    if ($user === null) {
+        return $email;
+    }
+
+    $vorname = trim($user["vorname"] ?? "");
+    $nachname = trim($user["nachname"] ?? "");
+
+    $fullName = trim($vorname . " " . $nachname);
+
+    return $fullName !== "" ? $fullName : $email;
+}
 /*
  * Ermittelt, ob ohne JavaScript auf einen Kommentar
  * geantwortet werden soll.
@@ -178,7 +202,14 @@ if ($replyAuthor === null) {
 
                             <p>
                                 <strong>
-                                    <?php echo htmlspecialchars($comment->getAuthor()); ?>
+                                    <?php
+                                    echo htmlspecialchars(
+                                            getCommentAuthorName(
+                                                    $comment->getAuthor(),
+                                                    $userManager
+                                            )
+                                    );
+                                    ?>
                                 </strong>
 
                                 <span>
@@ -313,7 +344,14 @@ if ($replyAuthor === null) {
 
                                             <p>
                                                 <strong>
-                                                    <?php echo htmlspecialchars($reply->getAuthor()); ?>
+                                                    <?php
+                                                    echo htmlspecialchars(
+                                                            getCommentAuthorName(
+                                                                    $reply->getAuthor(),
+                                                                    $userManager
+                                                            )
+                                                    );
+                                                    ?>
                                                 </strong>
 
                                                 <span>

content/updateArticle.php

@@ -27,6 +27,8 @@ $blocks = array_values($blocks);
 -->
 <form method="post" action="php/controller/updateArticle-controller.php?id=<?php if(isset($id) && !empty($id)){echo htmlspecialchars($id);}else{$_SESSION["message"] = "missing_id";} ?>" id="editor-form" enctype="multipart/form-data" class="article-editor-scope.editor-container article-editor-scope editor-container">
 
+    <?php csrf_field(); ?>
+
     <main class="editor-main">
         <?php include_once "includes/alertMessages.php"?>
 

css/main.css

@@ -154,21 +154,32 @@ h1 {
 
 .button {
     width: 100%;
-    padding: 12px;
+    padding: 14px;
     background-color: #2563eb;
     color: white;
-    border: none;
+    border: 2px solid transparent;
     border-radius: 8px;
     font-size: 1rem;
     font-weight: bold;
     cursor: pointer;
-    transition: background-color 0.2s, transform 0.2s, box-shadow 0.2s;
+    transition:
+            background-color 0.2s ease,
+            transform 0.2s ease,
+            box-shadow 0.2s ease,
+            border-color 0.2s ease;
 }
 
 .button:hover {
+    background-color: #1e40af;
+    border-color: #93c5fd;
+    transform: translateY(-3px) scale(1.01);
+    box-shadow: 0 8px 18px rgba(37, 99, 235, 0.35);
+}
+
+.button:active {
     background-color: #1d4ed8;
-    transform: translateY(-2px);
-    box-shadow: 0 4px 10px rgba(0,0,0,0.15);
+    transform: translateY(1px) scale(0.99);
+    box-shadow: 0 2px 5px rgba(37, 99, 235, 0.25);
 }
 
 .register-link {
@@ -225,4 +236,182 @@ h1 {
     text-align: center;
     text-decoration: none;
     box-sizing: border-box;
+}
+
+/* Deutlichere Klickreaktion für Kategorien */
+.category-link:active {
+    transform: translateY(1px);
+    box-shadow: none;
+}
+
+/* Sichtbare Tastatur-Markierung */
+.button:focus-visible,
+.category-link:focus-visible,
+.article-link a:focus-visible,
+.register-link a:focus-visible {
+    outline: 3px solid #fbbf24;
+    outline-offset: 3px;
+}
+/* Kommentarbereich */
+
+#comments-list {
+    display: flex;
+    flex-direction: column;
+    gap: 20px;
+    margin-bottom: 40px;
+}
+
+#comments-list > div,
+.comment {
+    background-color: #ffffff;
+    border: 1px solid #dbe3ec;
+    border-radius: 12px;
+    padding: 24px;
+    box-shadow: 0 4px 12px rgba(0, 0, 0, 0.06);
+    transition:
+            transform 0.2s ease,
+            box-shadow 0.2s ease,
+            border-color 0.2s ease;
+}
+
+#comments-list > div:hover,
+.comment:hover {
+    transform: translateY(-3px);
+    border-color: #93c5fd;
+    box-shadow: 0 8px 20px rgba(0, 0, 0, 0.12);
+}
+
+#comments-list textarea,
+#comment-content {
+    width: 100%;
+    box-sizing: border-box;
+    padding: 14px;
+    border: 1px solid #cbd5e1;
+    border-radius: 8px;
+    font-size: 1rem;
+    resize: vertical;
+    transition:
+            border-color 0.2s ease,
+            box-shadow 0.2s ease;
+}
+
+#comments-list textarea:focus,
+#comment-content:focus {
+    outline: none;
+    border-color: #2563eb;
+    box-shadow: 0 0 0 4px rgba(37, 99, 235, 0.18);
+}
+
+#comments-list a {
+    color: #2563eb;
+    font-weight: bold;
+    text-decoration: none;
+    border-radius: 4px;
+    transition:
+            color 0.2s ease,
+            background-color 0.2s ease;
+}
+
+#comments-list a:hover {
+    color: #1e40af;
+    background-color: #dbeafe;
+    text-decoration: underline;
+}
+
+#comments-list button {
+    cursor: pointer;
+}
+.delete-comment-button {
+     display: inline-block;
+     background: #ffffff;
+     color: #dc2626;
+     border: 2px solid #dc2626;
+     border-radius: 8px;
+     padding: 10px 18px;
+     font-size: 0.95rem;
+     font-weight: 600;
+     cursor: pointer;
+     transition:
+             background-color 0.25s ease,
+             color 0.25s ease,
+             transform 0.2s ease,
+             box-shadow 0.2s ease;
+ }
+
+.delete-comment-button:hover {
+    background: #dc2626;
+    color: #ffffff;
+    transform: translateY(-2px);
+    box-shadow: 0 6px 14px rgba(220,38,38,0.25);
+}
+
+.delete-comment-button:active {
+    transform: translateY(1px);
+    box-shadow: none;
+}
+.delete-comment-form {
+    margin-top: 12px;
+    margin-bottom: 12px;
+}
+/* Button zum Öffnen der Kommentarbearbeitung */
+.edit-comment-button {
+    display: inline-block;
+    width: auto;
+    padding: 10px 18px;
+    background-color: #2563eb;
+    color: #ffffff;
+    border: 2px solid #2563eb;
+    border-radius: 8px;
+    font-size: 0.95rem;
+    font-weight: 600;
+    cursor: pointer;
+    list-style: none;
+    transition:
+            background-color 0.2s ease,
+            border-color 0.2s ease,
+            transform 0.2s ease,
+            box-shadow 0.2s ease;
+}
+
+/* Entfernt das normale Dreieck in einigen Browsern */
+.edit-comment-button::-webkit-details-marker {
+    display: none;
+}
+
+/* Eigenes Symbol vor dem Text */
+.edit-comment-button::before {
+    content: "✏ ";
+}
+
+.edit-comment-button:hover {
+    background-color: #1e40af;
+    border-color: #1e40af;
+    transform: translateY(-2px);
+    box-shadow: 0 5px 12px rgba(37, 99, 235, 0.3);
+}
+
+.edit-comment-button:active {
+    transform: translateY(1px);
+    box-shadow: none;
+}
+
+.edit-comment-button:focus-visible {
+    outline: 3px solid #fbbf24;
+    outline-offset: 3px;
+}
+
+/* Abstand zwischen Bearbeiten und Löschen */
+.edit-comment-details {
+    margin-bottom: 12px;
+}
+
+/* Geöffneter Bearbeitungsbereich */
+.edit-comment-details[open] .edit-comment-button {
+    margin-bottom: 12px;
+    background-color: #1e40af;
+}
+
+/* Geändertes Symbol, wenn der Bereich geöffnet ist */
+.edit-comment-details[open] .edit-comment-button::before {
+    content: "▲ ";
 }

css/navbar.css

@@ -248,7 +248,7 @@ CSS für die navbar
         z-index: 1000;
         transition: left 0.3s ease;
         padding: 2rem 1rem;
-        box-shadow: 2px 0 10px rgba(0,0,0,0.5);
+        box-shadow: 2px 0 10px rgba(0, 0, 0, 0.5);
         overflow-y: auto;
 
         /* Genug Abstand oben rechts, damit Links nicht hinter dem X liegen */
@@ -328,5 +328,89 @@ CSS für die navbar
         padding: 0.8rem 1rem;
         cursor: pointer;
     }
+}
+    /* Deutlichere Hover-Effekte für die Navigation */
 
-}
+    .nav__dropdown-toggle,
+    .nav__link {
+        border-radius: 6px;
+        transition:
+                background-color 0.2s ease,
+                color 0.2s ease,
+                transform 0.2s ease;
+    }
+
+    .nav__dropdown-toggle:hover,
+    .nav__link:hover {
+        background-color: #ffffff;
+        color: #1d4ed8;
+        transform: translateY(-2px);
+    }
+
+    /* Sichtbare Reaktion beim Anklicken */
+    .nav__dropdown-toggle:active,
+    .nav__link:active {
+        transform: translateY(1px);
+    }
+
+    /* Deutlichere Effekte für Anmelden, Registrieren usw. */
+    .nav__button {
+        transition:
+                background-color 0.2s ease,
+                color 0.2s ease,
+                transform 0.2s ease,
+                box-shadow 0.2s ease;
+    }
+
+    .nav__button:hover {
+        background-color: #2563eb;
+        color: #ffffff;
+        transform: translateY(-2px);
+        box-shadow: 0 4px 10px rgba(0, 0, 0, 0.3);
+    }
+
+    .nav__button:active {
+        transform: translateY(1px);
+        box-shadow: none;
+    }
+
+    /* Deutlichere Hervorhebung der Einträge im Dropdown-Menü */
+    .nav__dropdown-menu a {
+        display: block;
+        transition:
+                background-color 0.2s ease,
+                color 0.2s ease,
+                padding-left 0.2s ease;
+    }
+
+    .nav__dropdown-menu a:hover {
+        background-color: #dbeafe;
+        color: #1d4ed8;
+        padding-left: 1.4rem;
+    }
+
+    /* Effekt für den Suchbutton */
+    .nav__search-button {
+        transition:
+                background-color 0.2s ease,
+                color 0.2s ease,
+                transform 0.2s ease;
+    }
+
+    .nav__search-button:hover {
+        background-color: #2563eb;
+        color: #ffffff;
+    }
+
+    .nav__search-button:active {
+        transform: scale(0.95);
+    }
+
+    /* Sichtbare Markierung bei Tastaturbedienung */
+    .nav a:focus-visible,
+    .nav button:focus-visible,
+    .nav input:focus-visible,
+    .nav label:focus-visible {
+        outline: 3px solid #fbbf24;
+        outline-offset: 3px;
+    }

index.php

@@ -36,7 +36,6 @@ include_once "php/controller/index-controller.php";
 
 <?php
 include_once 'includes/navbar.php';
-include_once "includes/alertMessages.php";
 
 // Dynamischer Inhalt
 if (isset($pfad) && $pfad !== "404" && file_exists('content/' . $pfad . '.php')) {

php/ajax/add-comment.php

@@ -4,6 +4,9 @@ if (session_status() === PHP_SESSION_NONE) {
 }
 
 require_once "../model/CommentManager.php";
+require_once "../model/UserManager.php";
+require_once "../model/ArticleManager.php";
+require_once "../../includes/csrf.php";
 
 /**
  * Prüft, ob die Anfrage durch JavaScript per AJAX gesendet wurde.
@@ -96,6 +99,17 @@ if (!isset($_SESSION["user_email"])) {
     );
 }
 
+/*
+ * CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird.
+ */
+if (!csrf_verify()) {
+    sendCommentResponse(
+        false,
+        "Deine Sitzung ist abgelaufen. Bitte lade die Seite neu und versuche es erneut.",
+        $articleId !== false ? $articleId : null
+    );
+}
+
 /*
  * Weitere Formulardaten einlesen.
  */
@@ -128,6 +142,18 @@ if ($articleId === false || $articleId === null) {
     );
 }
 
+/*
+ * Der Beitrag muss tatsächlich existieren.
+ */
+$existingArticle = ArticleManager::getInstance()->getArticle($articleId);
+if ($existingArticle === null) {
+    sendCommentResponse(
+        false,
+        "Der zugehörige Beitrag wurde nicht gefunden.",
+        null
+    );
+}
+
 if ($content === "") {
     sendCommentResponse(
         false,
@@ -152,6 +178,30 @@ if (
     );
 }
 
+/*
+ * Falls eine Eltern-ID angegeben wurde, muss dieser Kommentar
+ * tatsächlich existieren und zum selben Beitrag gehören.
+ */
+if ($parentCommentId !== null) {
+    $existingComments = CommentManager::getInstance()->getCommentsByArticle($articleId);
+    $parentExists = false;
+
+    foreach ($existingComments as $existingComment) {
+        if ($existingComment->getId() === $parentCommentId) {
+            $parentExists = true;
+            break;
+        }
+    }
+
+    if (!$parentExists) {
+        sendCommentResponse(
+            false,
+            "Der ausgewählte Kommentar wurde nicht gefunden.",
+            $articleId
+        );
+    }
+}
+
 try {
     $commentManager = CommentManager::getInstance();
 
@@ -162,13 +212,29 @@ try {
         $parentCommentId
     );
 
+    $userManager = UserManager::getInstance();
+    $user = $userManager->findUser($_SESSION["user_email"]);
+
+    $authorName = $_SESSION["user_email"];
+
+    if ($user !== null) {
+        $vorname = trim($user["vorname"] ?? "");
+        $nachname = trim($user["nachname"] ?? "");
+
+        $fullName = trim($vorname . " " . $nachname);
+
+        if ($fullName !== "") {
+            $authorName = $fullName;
+        }
+    }
+
     sendCommentResponse(
         true,
         "Der Kommentar wurde erfolgreich gespeichert.",
         $articleId,
         [
             "commentId" => $commentId,
-            "author" => $_SESSION["user_email"],
+            "author" => $authorName,
             "content" => $content,
             "created" => date("Y-m-d H:i:s"),
             "parentCommentId" => $parentCommentId

php/controller/createArticle-controller.php

@@ -6,6 +6,7 @@ require_once '../model/LocalArticleManager.php';
 require_once '../model/ArticleManager.php';
 require_once '../validator/article-validator.php';
 require_once '../../includes/article-block-helper.php';
+require_once '../../includes/csrf.php';
 
 if (!isset($_SESSION["user"])) {
     header("Location: index.php?pfad=login");
@@ -14,6 +15,13 @@ if (!isset($_SESSION["user"])) {
 
 if ($_SERVER["REQUEST_METHOD"] === "POST") {
 
+    // CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+    if (!csrf_verify()) {
+        $_SESSION["message"] = "invalid_csrf_token";
+        header("location: ../../index.php?pfad=createArticle");
+        exit();
+    }
+
     $uploadDir = __DIR__ . '/../../uploads/';
     if (!file_exists($uploadDir)) {
         mkdir($uploadDir, 0755, true);

php/controller/deleteAccount-controller.php

@@ -5,12 +5,24 @@ if (session_status() === PHP_SESSION_NONE) {
 
 require_once __DIR__ . "/../model/UserManager.php";
 require_once __DIR__ . "/../model/ArticleManager.php";
+require_once __DIR__ . "/../../includes/csrf.php";
 
 if (!isset($_SESSION["user"])) {
     header("Location: index.php?pfad=login");
     exit();
 }
 
+if ($_SERVER["REQUEST_METHOD"] !== "POST") {
+    header("Location: ../../index.php?pfad=profile");
+    exit();
+}
+
+if (!csrf_verify()) {
+    $_SESSION["message"] = "invalid_csrf_token";
+    header("Location: ../../index.php?pfad=profile");
+    exit();
+}
+
 /*
     Deregistrierung
     Funktion: Entfernt User aus der Datenbank und beendet die Session

php/controller/deleteArticle-controller.php

@@ -4,6 +4,7 @@ if (session_status() === PHP_SESSION_NONE) {
 }
 
 require_once __DIR__ . "/../model/ArticleManager.php";
+require_once __DIR__ . "/../../includes/csrf.php";
 
 if (!isset($_SESSION["user"])) {
     header("Location: index.php?pfad=login");
@@ -12,6 +13,13 @@ if (!isset($_SESSION["user"])) {
 
 if ($_SERVER["REQUEST_METHOD"] === "POST") {
 
+    // CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+    if (!csrf_verify()) {
+        $_SESSION["message"] = "invalid_csrf_token";
+        header("location: ../../index.php?pfad=profile");
+        exit();
+    }
+
     if (isset($_SESSION["user_email"])) {
         $user = $_SESSION["user_email"];
     } else {
@@ -22,9 +30,10 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
         exit();
     }
 
-    if (isset($_POST["id"]) && !empty($_POST["id"])) {
-        $id = $_POST["id"];
-    } else {
+    // Die Beitrags-ID muss eine gültige numerische ID sein.
+    $id = filter_input(INPUT_POST, "id", FILTER_VALIDATE_INT);
+
+    if ($id === false || $id === null) {
         $_SESSION["message"] = "missing_id";
         header("location: ../../index.php?pfad=profile");
         exit();
@@ -44,4 +53,4 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
     $_SESSION["message"] = "article_deleted";
     header("location: ../../index.php?pfad=profile");
     exit();
-}
+}

php/controller/deleteComment-controller.php

@@ -5,6 +5,7 @@ if (session_status() === PHP_SESSION_NONE) {
 }
 
 require_once __DIR__ . "/../model/CommentManager.php";
+require_once __DIR__ . "/../../includes/csrf.php";
 
 /*
  * Kommentare dürfen nur über ein POST-Formular gelöscht werden.
@@ -44,6 +45,23 @@ if (!isset($_SESSION["user_email"])) {
     exit();
 }
 
+// CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+if (!csrf_verify()) {
+    $_SESSION["comment_message"] = "Deine Sitzung ist abgelaufen. Bitte lade die Seite neu.";
+    $_SESSION["comment_message_type"] = "error";
+
+    if ($articleId !== false && $articleId !== null) {
+        header(
+            "Location: index.php?pfad=showArticle&id="
+            . urlencode((string) $articleId)
+            . "#comments"
+        );
+    } else {
+        header("Location: index.php");
+    }
+    exit();
+}
+
 /*
  * Kommentar-ID und Beitrags-ID müssen gültige Zahlen sein.
  */
@@ -102,4 +120,4 @@ header(
     . "#comments"
 );
 
-exit();
+exit();

php/controller/index-controller.php

@@ -20,6 +20,8 @@ if ($pfad === "login") {
     include_once "php/controller/confirm-register-controller.php";
 } elseif ($pfad === "confirm-password") {
     include_once "php/controller/confirm-password-controller.php";
+} elseif ($pfad === "profile") {
+    include_once "php/controller/profile-controller.php";
 } elseif ($pfad === "updateComment") {
     include_once "php/controller/updateComment-controller.php";
 } elseif($pfad === "deleteComment") {

php/controller/like-controller.php

@@ -5,6 +5,12 @@ if (session_status() === PHP_SESSION_NONE) {
 
 require_once __DIR__ . '/../model/Article.php';
 require_once __DIR__ . '/../model/ArticleManager.php';
+require_once __DIR__ . '/../../includes/csrf.php';
+
+if ($_SERVER["REQUEST_METHOD"] !== "POST") {
+    header("Location: ../../index.php");
+    exit();
+}
 
 // 2. Prüfen, ob eine gültige Artikel-ID übergeben wurde
 if (isset($_GET["id"]) && !empty($_GET["id"])) {
@@ -17,6 +23,13 @@ if (isset($_GET["id"]) && !empty($_GET["id"])) {
         exit();
     }
 
+    // CSRF-Token prüfen, bevor der Like-Status verändert wird
+    if (!csrf_verify()) {
+        $_SESSION["message"] = "invalid_csrf_token";
+        header("Location: ../../index.php?pfad=showArticle&id=" . $articleId);
+        exit();
+    }
+
     try {
         $articleManager = ArticleManager::getInstance();
         $articleManager->toggleLike($articleId, $userEmail);

php/controller/logout-controller.php

@@ -6,5 +6,5 @@ if (session_status() === PHP_SESSION_NONE) {
 $_SESSION = [];
 session_destroy();
 
-header("Location: ../../index.php");
+header("Location: index.php");
 exit();

php/controller/profile-controller.php

@@ -5,6 +5,7 @@ require_once "php/model/Article.php";
 require_once "php/model/ArticleManager.php";
 require_once "php/model/CommentManager.php";
 require_once "php/validator/user-validator.php";
+require_once "includes/csrf.php";
 
 $error = null;
 
@@ -27,6 +28,7 @@ try {
     }
 
     if ($_SERVER["REQUEST_METHOD"] === "POST" && isset($_POST["saveProfile"])) {
+
         $oldEmail = $_SESSION["user_email"];
 
         $newEmail = trim($_POST["email"] ?? "");
@@ -34,7 +36,12 @@ try {
         $nachname = trim($_POST["nachname"] ?? "");
         $password = $_POST["password"] ?? "";
 
-        if (!userEmailValidator($newEmail)) {
+        if (!csrf_verify()) {
+            // CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+            $error = "Deine Sitzung ist abgelaufen. Bitte lade die Seite neu und versuche es erneut.";
+            $_GET["edit"] = "1";
+
+        } elseif (!userEmailValidator($newEmail)) {
             $error = "Bitte gib eine gültige E-Mail-Adresse ein.";
             $_GET["edit"] = "1";
 

php/controller/showArticle-controller.php

@@ -7,10 +7,14 @@ require_once 'php/model/Article.php';
 require_once 'php/model/ArticleManager.php';
 require_once 'php/model/UserManager.php';
 require_once 'php/model/CommentManager.php';
+require_once 'php/validator/article-validator.php';
 
-if (isset($_GET["id"]) && !empty($_GET["id"])){
+// Die übergebene ID muss eine gültige, positive Zahl sein, bevor sie
+// weiterverwendet wird. Vorher wurde jeder nicht-leere Wert akzeptiert.
+$id = isset($_GET["id"]) ? articleIdValidator($_GET["id"]) : false;
+
+if ($id !== false) {
     try {
-        $id = $_GET["id"];
         $articleManager = ArticleManager::getInstance();
         $article = $articleManager->getArticle($id);
         if($article != null){
@@ -38,7 +42,7 @@ if (isset($_GET["id"]) && !empty($_GET["id"])){
         }
 
         $commentManager = CommentManager::getInstance();
-        $comments = $commentManager->getCommentsByArticle($_GET["id"]);
+        $comments = $commentManager->getCommentsByArticle($id); // NEU: validierte ID statt rohem $_GET["id"]
 
         foreach ($comments as $comment) {
             if ($comment->isReply()) {

php/controller/updateArticle-controller.php

@@ -8,6 +8,7 @@ require_once '../model/ArticleManager.php';
 require_once '../model/Article.php';
 require_once '../validator/article-validator.php';
 require_once '../../includes/article-block-helper.php';
+require_once '../../includes/csrf.php'; // NEU: CSRF-Schutz
 
 if (!isset($_SESSION["user"])) {
     header("Location: index.php?pfad=login");
@@ -16,9 +17,17 @@ if (!isset($_SESSION["user"])) {
 
 if ($_SERVER["REQUEST_METHOD"] === "POST") {
 
-    if (isset($_GET["id"]) && !empty($_GET["id"])) {
-        $id = $_GET["id"];
-    } else {
+    // CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+    if (!csrf_verify()) {
+        $_SESSION["message"] = "invalid_csrf_token";
+        header("location: ../../index.php?pfad=updateArticle");
+        exit();
+    }
+
+    // Die Beitrags-ID muss eine gültige numerische ID sein
+    $id = filter_input(INPUT_GET, "id", FILTER_VALIDATE_INT);
+
+    if ($id === false || $id === null) {
         $_SESSION["message"] = "missing_id";
         header("location: ../../index.php?pfad=updateArticle");
         exit();
@@ -27,6 +36,14 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
     try {
         $articleManager = ArticleManager::getInstance();
         $article = $articleManager->getArticle($id);
+
+        // Existenz des Beitrags prüfen, bevor auf $article zugegriffen wird.
+        if ($article === null) {
+            $_SESSION["message"] = "missing_id";
+            header("location: ../../index.php?pfad=updateArticle");
+            exit();
+        }
+
         if ($article->getAuthor() != $_SESSION["user_email"]) {
             $_SESSION["message"] = "unauthorized_access";
             header("location: ../../index.php");

php/controller/updateComment-controller.php

@@ -5,6 +5,7 @@ if (session_status() === PHP_SESSION_NONE) {
 }
 
 require_once "php/model/CommentManager.php";
+require_once "includes/csrf.php";
 
 if ($_SERVER["REQUEST_METHOD"] !== "POST") {
     header("Location: index.php");
@@ -16,6 +17,14 @@ if (!isset($_SESSION["user_email"])) {
     exit();
 }
 
+// CSRF-Token prüfen, bevor irgendeine Änderung vorgenommen wird
+if (!csrf_verify()) {
+    $_SESSION["comment_message"] = "Deine Sitzung ist abgelaufen. Bitte lade die Seite neu.";
+    $_SESSION["comment_message_type"] = "error";
+    header("Location: index.php");
+    exit();
+}
+
 $commentId = filter_input(
     INPUT_POST,
     "comment_id",
@@ -89,4 +98,4 @@ header(
     . urlencode((string) $articleId)
     . "#comments"
 );
-exit();
+exit();

php/model/DatabaseArticleManager.php

@@ -63,12 +63,9 @@ class DatabaseArticleManager implements ArticleManagerDAO {
                     VALUES (:title, :content, :author, :category, :tags);";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
 
             // Verknüpft die übergebenen Parameter exakt mit den SQL-Platzhaltern
-            $success = $command->execute([
+            $command->execute([
                 ":title"    => $title,
                 ":content"  => $content,
                 ":author"   => $author,
@@ -76,14 +73,10 @@ class DatabaseArticleManager implements ArticleManagerDAO {
                 ":tags"     => $tags
             ]);
 
-            if (!$success) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             return intval($db->lastInsertId());
 
         } catch (PDOException $e) {
-            throw new InternalServerErrorException($e->getMessage());
+            throw new InternalServerErrorException("internal_error");
         }
     }
 
@@ -106,11 +99,8 @@ class DatabaseArticleManager implements ArticleManagerDAO {
                     WHERE id = :id;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
 
-            $success = $command->execute([
+            $command->execute([
                 ":id"       => $id,
                 ":title"    => $article->getTitle(),
                 ":content"  => $article->getContent(),
@@ -120,7 +110,7 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             ]);
 
             // rowCount() prüft, ob eine Zeile mit dieser ID existierte und geändert werden konnte
-            if (!$success || $command->rowCount() === 0) {
+            if ($command->rowCount() === 0) {
                 // Falls die ID nicht existiert, prüfen wir, ob sie überhaupt da ist
                 if (!$this->getArticle($id)) {
                     throw new NotFoundException("missing_id");
@@ -148,13 +138,7 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $sql = "DELETE FROM articles WHERE id = :id;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
-            if (!$command->execute([":id" => $id])) {
-                throw new InternalServerErrorException("internal_error");
-            }
+            $command->execute([":id" => $id]);
         } catch (PDOException $exc) {
             throw new InternalServerErrorException("internal_error");
         }
@@ -167,10 +151,6 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $sql = "SELECT * FROM articles WHERE id = :id;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             $command->execute([":id" => $id]);
             $row = $command->fetch(PDO::FETCH_ASSOC);
 
@@ -202,10 +182,6 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $sql = "SELECT * FROM articles;";
 
             $command = $db->query($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             $rows = $command->fetchAll(PDO::FETCH_ASSOC);
             $articles = [];
 
@@ -234,10 +210,6 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $sql = "SELECT * FROM articles WHERE author = :author;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             $command->execute([":author" => $author]);
             $rows = $command->fetchAll(PDO::FETCH_ASSOC);
             $filteredArticles = [];
@@ -270,10 +242,6 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $sql = "SELECT * FROM articles WHERE category = :category;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             $command->execute([":category" => $category]);
             $rows = $command->fetchAll(PDO::FETCH_ASSOC);
             $filteredArticles = [];
@@ -312,35 +280,29 @@ class DatabaseArticleManager implements ArticleManagerDAO {
             $db = $this->getConnection();
 
             $sql = "SELECT id, title, content, author, category, tags, created 
-                    FROM articles 
-                    WHERE title LIKE :keyword 
-                       OR content LIKE :keyword
-                       OR tags LIKE :keyword";
+                FROM articles 
+                WHERE title LIKE :keyword 
+                OR content LIKE :keyword
+                OR tags LIKE :keyword;";
 
             $command = $db->prepare($sql);
-            if (!$command) {
-                throw new InternalServerErrorException("internal_error");
-            }
 
             // Wildcards für die Suche hinzufügen
             $searchParam = '%' . $cleankeyword . '%';
 
-            $success = $command->execute([
+            $command->execute([
                 ":keyword" => $searchParam
             ]);
 
-            if (!$success) {
-                throw new InternalServerErrorException("internal_error");
-            }
-
             $rows = $command->fetchAll(PDO::FETCH_ASSOC);
             $filteredArticles = [];
 
             foreach ($rows as $row) {
-                $likes = $this->getLikesForArticle(intval($row['id']));
+                $articleId = intval($row['id']);
+                $likes = $this->getLikesForArticle($articleId);
 
                 $filteredArticles[] = new Article(
-                    intval($row['id']),
+                    $articleId,
                     $row['title'] ?? '',
                     $row['content'] ?? '',
                     $row['author'] ?? '',

php/validator/article-validator.php

@@ -1,5 +1,20 @@
 <?php
 
+/**
+ * NEU: Prüft, ob ein übergebener Wert eine gültige, positive
+ * Beitrags-ID ist. Wird überall dort verwendet, wo eine Artikel-ID
+ * aus $_GET oder $_POST entgegengenommen wird
+ *
+ * @param mixed $id
+ * @return int|false Die validierte ID als int, oder false bei Ungültigkeit
+ */
+function articleIdValidator($id)
+{
+    $options = ["options" => ["min_range" => 1]];
+
+    return filter_var($id, FILTER_VALIDATE_INT, $options);
+}
+
 /**
  * Prüft, ob der Titel die folgenden Bedingungen erfüllt:
  * Buchstaben von a-z; A-Z