Compare commits
2 Commits
e9403801d6
...
742ef39f05
| Author | SHA1 | Date | |
|---|---|---|---|
| 742ef39f05 | |||
| 489c4fa070 |
+274
@@ -0,0 +1,274 @@
|
||||
package de.medapp.wunddoku.data.repository
|
||||
|
||||
import android.database.sqlite.SQLiteFullException
|
||||
import android.net.Uri
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import de.medapp.wunddoku.pdf.PdfExportError
|
||||
import de.medapp.wunddoku.pdf.PdfExportResult
|
||||
import de.medapp.wunddoku.pdf.PdfToImagesResult
|
||||
import de.medapp.wunddoku.testutil.FailingPhotoDao
|
||||
import de.medapp.wunddoku.testutil.FailingPhotoStorage
|
||||
import de.medapp.wunddoku.testutil.FailingSignatureDao
|
||||
import de.medapp.wunddoku.testutil.FailingSignatureStorage
|
||||
import de.medapp.wunddoku.testutil.TestEnvironment
|
||||
import de.medapp.wunddoku.testutil.ThrowingPdfExporter
|
||||
import de.medapp.wunddoku.testutil.ThrowingPdfToImagesConverter
|
||||
import de.medapp.wunddoku.testutil.buildRepository
|
||||
import de.medapp.wunddoku.testutil.expectThrowsSuspend
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import de.medapp.wunddoku.testutil.signatureBitmap
|
||||
import kotlinx.coroutines.CancellationException
|
||||
import kotlinx.coroutines.flow.first
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.io.IOException
|
||||
|
||||
/**
|
||||
* Fehler- und Datenverlust-Tests für [DocumentationRepository] gegen eine echte In-Memory-
|
||||
* Room-Datenbank: Speichermangel (Datenbank/Dateisystem voll, Arbeitsspeicher), halbe
|
||||
* Ergebnisse, verwaiste Dateien und das "wirft-nie"-Verhalten des PDF-Exports.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class DocumentationRepositoryErrorHandlingTest {
|
||||
|
||||
private lateinit var env: TestEnvironment
|
||||
private val someUri: Uri = Uri.parse("content://test/bild/1")
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
env = TestEnvironment()
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
env.close()
|
||||
}
|
||||
|
||||
private suspend fun newDocumentationId(): String {
|
||||
env.insertPatient()
|
||||
return env.documentationRepository.createEmpty("patient-1").id
|
||||
}
|
||||
|
||||
// --- Foto-Import ---------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun addPhoto_bei_fehlgeschlagenem_dateiimport_legt_keinen_db_eintrag_an() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { IOException("Bild defekt (Test)") } }
|
||||
val repo = env.buildRepository(photoStorage = storage)
|
||||
|
||||
expectThrowsSuspend<IOException> { repo.addPhoto(documentationId, someUri) }
|
||||
|
||||
assertTrue(env.db.photoDao().getForDocumentation(documentationId).isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun addPhoto_bei_speichermangel_im_arbeitsspeicher_legt_keinen_db_eintrag_an() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { OutOfMemoryError("Test") } }
|
||||
val repo = env.buildRepository(photoStorage = storage)
|
||||
|
||||
expectThrowsSuspend<OutOfMemoryError> { repo.addPhoto(documentationId, someUri) }
|
||||
|
||||
assertTrue(env.db.photoDao().getForDocumentation(documentationId).isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun addPhoto_bei_voller_datenbank_entfernt_die_bereits_importierte_datei() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingPhotoStorage()
|
||||
val photoDao = FailingPhotoDao(env.db.photoDao()).apply {
|
||||
insertFailure = SQLiteFullException("database or disk is full")
|
||||
}
|
||||
val repo = env.buildRepository(photoStorage = storage, photoDao = photoDao)
|
||||
|
||||
expectThrowsSuspend<SQLiteFullException> { repo.addPhoto(documentationId, someUri) }
|
||||
|
||||
assertEquals(1, storage.delegate.imported.size)
|
||||
assertEquals("verwaiste Datei muss entfernt werden", 1, storage.delegate.deleted.size)
|
||||
assertEquals(documentationId, storage.delegate.deleted.single().first)
|
||||
assertTrue(env.db.photoDao().getForDocumentation(documentationId).isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun addPhoto_funktioniert_nach_einem_fehlgeschlagenen_versuch_wieder() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { call -> if (call == 1) IOException("einmalig") else null } }
|
||||
val repo = env.buildRepository(photoStorage = storage)
|
||||
|
||||
expectThrowsSuspend<IOException> { repo.addPhoto(documentationId, someUri) }
|
||||
repo.addPhoto(documentationId, someUri)
|
||||
|
||||
assertEquals(1, env.db.photoDao().getForDocumentation(documentationId).size)
|
||||
}
|
||||
|
||||
// --- Signaturen ----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun saveSignature_bei_dateifehler_legt_weder_db_eintrag_noch_registereintrag_an() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingSignatureStorage().apply { saveFailure = IOException("Speicher voll (Test)") }
|
||||
val repo = env.buildRepository(signatureStorage = storage)
|
||||
|
||||
expectThrowsSuspend<IOException> { repo.saveSignature(documentationId, "Pfleger Paul", signatureBitmap()) }
|
||||
|
||||
assertTrue(env.db.signatureDao().getForDocumentation(documentationId).isEmpty())
|
||||
assertNull(env.woundCarerRepository.getMostRecentlyUsed())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun saveSignature_bei_voller_datenbank_entfernt_die_gespeicherte_datei() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val storage = FailingSignatureStorage()
|
||||
val signatureDao = FailingSignatureDao(env.db.signatureDao()).apply {
|
||||
insertFailure = SQLiteFullException("database or disk is full")
|
||||
}
|
||||
val repo = env.buildRepository(signatureStorage = storage, signatureDao = signatureDao)
|
||||
|
||||
expectThrowsSuspend<SQLiteFullException> { repo.saveSignature(documentationId, "Pfleger Paul", signatureBitmap()) }
|
||||
|
||||
assertEquals(1, storage.delegate.saved.size)
|
||||
assertEquals("verwaiste PNG-Datei muss entfernt werden", 1, storage.delegate.deleted.size)
|
||||
assertTrue(env.db.signatureDao().getForDocumentation(documentationId).isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun saveSignature_bleibt_erfolgreich_wenn_nur_das_wundversorger_register_scheitert() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val brokenRegisterStorage = FailingSignatureStorage().apply { saveFailure = IOException("Register-Speicher voll") }
|
||||
val brokenRegister = WoundCarerRepository(env.db.woundCarerDao(), brokenRegisterStorage)
|
||||
val repo = env.buildRepository(woundCarerRepository = brokenRegister)
|
||||
|
||||
val signature = repo.saveSignature(documentationId, "Pfleger Paul", signatureBitmap())
|
||||
|
||||
assertEquals("Pfleger Paul", signature.signerName)
|
||||
assertEquals(
|
||||
"Signatur der Dokumentation muss gespeichert sein",
|
||||
1,
|
||||
env.db.signatureDao().getForDocumentation(documentationId).size,
|
||||
)
|
||||
}
|
||||
|
||||
// --- Fortsetzen ----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun fortsetzen_raeumt_bereits_kopierte_fotos_der_gescheiterten_kopie_auf() = runDbTest {
|
||||
val sourceId = newDocumentationId()
|
||||
env.documentationRepository.addPhoto(sourceId, someUri)
|
||||
env.documentationRepository.addPhoto(sourceId, someUri)
|
||||
env.photoStorage.failOnDuplicateCall = 2
|
||||
|
||||
expectThrowsSuspend<IOException> { env.documentationRepository.continueDocumentation(sourceId) }
|
||||
|
||||
val attemptedTarget = env.photoStorage.duplicated.first().targetDocumentationId
|
||||
assertTrue(
|
||||
"Ordner der nie entstandenen Dokumentation muss gelöscht werden",
|
||||
attemptedTarget in env.photoStorage.deletedAll,
|
||||
)
|
||||
assertEquals("keine halbe Dokumentation", 1, env.documentationRepository.observeAll().first().size)
|
||||
assertTrue(env.db.photoDao().getForDocumentation(attemptedTarget).isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fortsetzen_laesst_quelle_und_deren_fotos_bei_fehler_unberuehrt() = runDbTest {
|
||||
val sourceId = newDocumentationId()
|
||||
env.documentationRepository.addPhoto(sourceId, someUri)
|
||||
env.photoStorage.failOnDuplicateCall = 1
|
||||
|
||||
expectThrowsSuspend<IOException> { env.documentationRepository.continueDocumentation(sourceId) }
|
||||
|
||||
assertEquals(1, env.db.photoDao().getForDocumentation(sourceId).size)
|
||||
assertFalse(sourceId in env.photoStorage.deletedAll)
|
||||
}
|
||||
|
||||
// --- PDF-Export wirft nie ------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun exportPdf_uebersetzt_out_of_memory_in_ein_fehlerergebnis() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val repo = env.buildRepository(pdfExporter = ThrowingPdfExporter(OutOfMemoryError("Test")))
|
||||
|
||||
val result = repo.exportPdf(documentationId)
|
||||
|
||||
assertEquals(PdfExportResult.Failure(PdfExportError.OutOfMemory), result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun exportPdf_uebersetzt_speicher_voll_in_ein_fehlerergebnis() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val repo = env.buildRepository(
|
||||
pdfExporter = ThrowingPdfExporter(IOException("write failed: ENOSPC (No space left on device)")),
|
||||
)
|
||||
|
||||
val result = repo.exportPdf(documentationId)
|
||||
|
||||
assertEquals(PdfExportResult.Failure(PdfExportError.InsufficientStorage), result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun exportPdf_gibt_bei_unerwarteten_fehlern_keine_technischen_details_weiter() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val repo = env.buildRepository(
|
||||
pdfExporter = ThrowingPdfExporter(RuntimeException("/files/pdf/2026_Max_Mustermann.pdf kaputt")),
|
||||
)
|
||||
|
||||
val result = repo.exportPdf(documentationId)
|
||||
|
||||
assertTrue(result is PdfExportResult.Failure)
|
||||
val error = (result as PdfExportResult.Failure).error
|
||||
assertTrue(error is PdfExportError.Unexpected)
|
||||
assertFalse((error as PdfExportError.Unexpected).message.contains("Mustermann"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun exportPdf_reicht_coroutine_abbruch_weiter() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
val repo = env.buildRepository(pdfExporter = ThrowingPdfExporter(CancellationException("abgebrochen")))
|
||||
|
||||
expectThrowsSuspend<CancellationException> { repo.exportPdf(documentationId) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun exportPdf_bei_geschlossener_datenbank_liefert_fehler_statt_exception() = runDbTest {
|
||||
val documentationId = newDocumentationId()
|
||||
env.db.close()
|
||||
|
||||
val result = env.documentationRepository.exportPdf(documentationId)
|
||||
|
||||
assertTrue("erwartet Failure, war $result", result is PdfExportResult.Failure)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun convertPdfToImages_uebersetzt_exceptions_in_fehlerergebnisse() = runDbTest {
|
||||
val file = File("/fake/x.pdf")
|
||||
|
||||
val oom = env.buildRepository(pdfToImagesConverter = ThrowingPdfToImagesConverter(OutOfMemoryError()))
|
||||
.convertPdfToImages("doc", file)
|
||||
val full = env.buildRepository(
|
||||
pdfToImagesConverter = ThrowingPdfToImagesConverter(IOException("No space left on device")),
|
||||
).convertPdfToImages("doc", file)
|
||||
val other = env.buildRepository(pdfToImagesConverter = ThrowingPdfToImagesConverter(IllegalStateException("x")))
|
||||
.convertPdfToImages("doc", file)
|
||||
|
||||
assertEquals(PdfToImagesResult.Failure.OutOfMemory, oom)
|
||||
assertEquals(PdfToImagesResult.Failure.InsufficientStorage, full)
|
||||
assertTrue(other is PdfToImagesResult.Failure.Unexpected)
|
||||
}
|
||||
|
||||
// --- Sonstiges -----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun setChecked_mit_unbekannter_id_wirft_nicht() = runDbTest {
|
||||
newDocumentationId()
|
||||
|
||||
env.documentationRepository.setChecked("gibt-es-nicht", true)
|
||||
env.documentationRepository.updateFreeText("gibt-es-nicht", "Text")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,222 @@
|
||||
package de.medapp.wunddoku.media
|
||||
|
||||
import android.graphics.Bitmap
|
||||
import android.graphics.Color
|
||||
import android.net.Uri
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import de.medapp.wunddoku.testutil.expectThrowsSuspend
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotNull
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.util.UUID
|
||||
|
||||
/**
|
||||
* Fehlerbehandlung von [InternalPhotoStorage] mit ECHTEN Dateien im App-Speicher: defekte,
|
||||
* leere oder nicht vorhandene Bilder, große Bilder (Speichermangel) sowie "kein halbes
|
||||
* Ergebnis zurücklassen".
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class PhotoStorageErrorHandlingTest {
|
||||
|
||||
private val context = InstrumentationRegistry.getInstrumentation().targetContext
|
||||
private lateinit var storage: InternalPhotoStorage
|
||||
private lateinit var documentationId: String
|
||||
private lateinit var workDir: File
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
storage = InternalPhotoStorage(context)
|
||||
// Eigene, zufällige Dokumentations-ID je Test: keine Berührung echter App-Daten.
|
||||
documentationId = "test-${UUID.randomUUID()}"
|
||||
workDir = File(context.cacheDir, "errtest-${UUID.randomUUID()}").apply { mkdirs() }
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
File(File(context.filesDir, "photos"), documentationId).deleteRecursively()
|
||||
workDir.deleteRecursively()
|
||||
}
|
||||
|
||||
private fun docDir() = File(File(context.filesDir, "photos"), documentationId)
|
||||
|
||||
private fun filesInDocDir(): List<File> = docDir().listFiles()?.toList().orEmpty()
|
||||
|
||||
private fun writeJpeg(name: String, width: Int, height: Int): File {
|
||||
val file = File(workDir, name)
|
||||
val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888).apply { eraseColor(Color.RED) }
|
||||
file.outputStream().use { bitmap.compress(Bitmap.CompressFormat.JPEG, 90, it) }
|
||||
bitmap.recycle()
|
||||
return file
|
||||
}
|
||||
|
||||
private fun uriOf(file: File): Uri = Uri.fromFile(file)
|
||||
|
||||
// --- Bildfehler beim Import ----------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun import_einer_textdatei_statt_bild_wirft_und_hinterlaesst_keine_datei() = runDbTest {
|
||||
val notAnImage = File(workDir, "kein_bild.jpg").apply { writeText("Das ist kein Bild.") }
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, uriOf(notAnImage)) }
|
||||
|
||||
assertTrue(filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun import_einer_leeren_datei_wirft_und_hinterlaesst_keine_datei() = runDbTest {
|
||||
val empty = File(workDir, "leer.jpg").apply { createNewFile() }
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, uriOf(empty)) }
|
||||
|
||||
assertTrue(filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun import_einer_abgeschnittenen_zufallsdatei_wirft_statt_abzustuerzen() = runDbTest {
|
||||
val garbage = File(workDir, "muell.jpg").apply { writeBytes(ByteArray(2048) { (it * 31).toByte() }) }
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, uriOf(garbage)) }
|
||||
|
||||
assertTrue(filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun import_einer_nicht_mehr_vorhandenen_datei_wirft() = runDbTest {
|
||||
val missing = File(workDir, "gibt_es_nicht.jpg")
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, uriOf(missing)) }
|
||||
|
||||
assertTrue(filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun import_mit_ungueltiger_content_uri_wirft() = runDbTest {
|
||||
val invalid = Uri.parse("content://de.medapp.gibt.es.nicht/bild/1")
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, invalid) }
|
||||
|
||||
assertTrue(filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun nach_einem_fehlgeschlagenen_import_funktioniert_der_naechste_import_normal() = runDbTest {
|
||||
val broken = File(workDir, "kaputt.jpg").apply { writeText("x") }
|
||||
val good = writeJpeg("gut.jpg", 200, 100)
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.importFrom(documentationId, uriOf(broken)) }
|
||||
val fileName = storage.importFrom(documentationId, uriOf(good))
|
||||
|
||||
assertTrue(storage.resolve(documentationId, fileName).exists())
|
||||
assertEquals(1, filesInDocDir().size)
|
||||
}
|
||||
|
||||
// --- Speichermangel: große Bilder ----------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun sehr_grosses_bild_wird_speicherschonend_heruntergerechnet_importiert() = runDbTest {
|
||||
// 8000 x 300: viele Megapixel entlang der langen Kante, aber als Testbild selbst günstig.
|
||||
val big = writeJpeg("gross.jpg", 8000, 300)
|
||||
|
||||
val fileName = storage.importFrom(documentationId, uriOf(big))
|
||||
|
||||
val bounds = android.graphics.BitmapFactory.Options().apply { inJustDecodeBounds = true }
|
||||
android.graphics.BitmapFactory.decodeFile(storage.resolve(documentationId, fileName).absolutePath, bounds)
|
||||
val longest = maxOf(bounds.outWidth, bounds.outHeight)
|
||||
assertTrue("gespeichert wurde ${bounds.outWidth}x${bounds.outHeight}", longest in 1 until 2 * ImageDownsampler.MAX_STORED_DIMENSION_PX)
|
||||
}
|
||||
|
||||
// --- Datei fehlt/defekt nach dem Import (Vorschau, PDF) ------------------------------
|
||||
|
||||
@Test
|
||||
fun thumbnail_einer_fehlenden_datei_liefert_null() = runDbTest {
|
||||
assertNull(storage.decodeThumbnail(documentationId, "fehlt.jpg", 300))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun thumbnail_einer_beschaedigten_datei_liefert_null_statt_abzustuerzen() = runDbTest {
|
||||
val target = storage.resolve(documentationId, "defekt.jpg")
|
||||
target.parentFile!!.mkdirs()
|
||||
target.writeBytes(ByteArray(512) { 7 })
|
||||
|
||||
assertNull(storage.decodeThumbnail(documentationId, "defekt.jpg", 300))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decodeFitted_einer_fehlenden_oder_beschaedigten_datei_liefert_null() = runDbTest {
|
||||
assertNull(storage.decodeFitted(documentationId, "fehlt.jpg", 500, 800))
|
||||
|
||||
val target = storage.resolve(documentationId, "defekt.jpg")
|
||||
target.parentFile!!.mkdirs()
|
||||
target.writeBytes(ByteArray(512) { 7 })
|
||||
assertNull(storage.decodeFitted(documentationId, "defekt.jpg", 500, 800))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decodeFitted_mit_null_zielgroesse_stuerzt_nicht_ab() = runDbTest {
|
||||
val good = writeJpeg("gut.jpg", 200, 100)
|
||||
val fileName = storage.importFrom(documentationId, uriOf(good))
|
||||
|
||||
// Ungültige Zielgröße (0) darf höchstens null liefern, aber keine Exception werfen.
|
||||
storage.decodeFitted(documentationId, fileName, 0, 0)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decodeFitted_vergroessert_nie_ueber_die_native_aufloesung() = runDbTest {
|
||||
val small = writeJpeg("klein.jpg", 100, 50)
|
||||
val fileName = storage.importFrom(documentationId, uriOf(small))
|
||||
|
||||
val bitmap = storage.decodeFitted(documentationId, fileName, 4000, 4000)
|
||||
|
||||
assertNotNull(bitmap)
|
||||
assertTrue(bitmap!!.width <= 100 && bitmap.height <= 50)
|
||||
bitmap.recycle()
|
||||
}
|
||||
|
||||
// --- Kopieren (Dokumentation fortsetzen) ---------------------------------------------
|
||||
|
||||
@Test
|
||||
fun duplicate_einer_fehlenden_quelldatei_wirft_und_hinterlaesst_keine_zieldatei() = runDbTest {
|
||||
val targetId = "test-${UUID.randomUUID()}"
|
||||
try {
|
||||
expectThrowsSuspend<Exception> { storage.duplicate(documentationId, "fehlt.jpg", targetId) }
|
||||
|
||||
val targetDir = File(File(context.filesDir, "photos"), targetId)
|
||||
assertTrue(targetDir.listFiles().orEmpty().isEmpty())
|
||||
} finally {
|
||||
File(File(context.filesDir, "photos"), targetId).deleteRecursively()
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun duplicate_erzeugt_eine_eigenstaendige_kopie() = runDbTest {
|
||||
val good = writeJpeg("gut.jpg", 200, 100)
|
||||
val fileName = storage.importFrom(documentationId, uriOf(good))
|
||||
val targetId = "test-${UUID.randomUUID()}"
|
||||
try {
|
||||
val copy = storage.duplicate(documentationId, fileName, targetId)
|
||||
|
||||
storage.delete(documentationId, fileName)
|
||||
assertTrue("Kopie muss das Löschen des Originals überleben", storage.resolve(targetId, copy).exists())
|
||||
} finally {
|
||||
File(File(context.filesDir, "photos"), targetId).deleteRecursively()
|
||||
}
|
||||
}
|
||||
|
||||
// --- Löschen -------------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun loeschen_nicht_vorhandener_dateien_und_ordner_wirft_nicht() = runDbTest {
|
||||
storage.delete(documentationId, "gibt_es_nicht.jpg")
|
||||
storage.deleteAll(documentationId)
|
||||
assertFalse(docDir().exists())
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,228 @@
|
||||
package de.medapp.wunddoku.pdf
|
||||
|
||||
import android.graphics.Bitmap
|
||||
import android.graphics.pdf.PdfRenderer
|
||||
import android.net.Uri
|
||||
import android.os.ParcelFileDescriptor
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import de.medapp.wunddoku.media.PhotoStorage
|
||||
import de.medapp.wunddoku.signature.SignatureStorage
|
||||
import de.medapp.wunddoku.testutil.FakePhotoStorage
|
||||
import de.medapp.wunddoku.testutil.FakeSignatureStorage
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.time.LocalDate
|
||||
import java.util.UUID
|
||||
|
||||
/**
|
||||
* Fehlerbehandlung des echten [AndroidPdfDocumentExporter] (echte Dateien im App-Speicher):
|
||||
* Schreibfehler, kein Datenverlust bereits vorhandener PDFs, keine halbfertigen Dateien sowie
|
||||
* graceful degradation bei fehlenden/defekten Fotos und Signaturen.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class PdfExportErrorHandlingTest {
|
||||
|
||||
private val context = InstrumentationRegistry.getInstrumentation().targetContext
|
||||
private val documentationId = "test-${UUID.randomUUID()}"
|
||||
private val fileName = "2026-08-19_Max_Mustermann_1980-03-14.pdf"
|
||||
|
||||
private val pdfRoot get() = File(context.filesDir, "pdf")
|
||||
private val targetDir get() = File(pdfRoot, documentationId)
|
||||
private val targetFile get() = File(targetDir, fileName)
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
pdfRoot.mkdirs()
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
targetDir.deleteRecursively()
|
||||
}
|
||||
|
||||
private fun exporter(
|
||||
photoStorage: PhotoStorage = FakePhotoStorage(),
|
||||
signatureStorage: SignatureStorage = FakeSignatureStorage(),
|
||||
) = AndroidPdfDocumentExporter(context, photoStorage, signatureStorage)
|
||||
|
||||
private fun model(photoCount: Int = 0, signatureCount: Int = 0) = PdfExportModel(
|
||||
documentationId = documentationId,
|
||||
fileName = fileName,
|
||||
patientFullName = "Max Mustermann",
|
||||
patientBirthDate = LocalDate.of(1980, 3, 14),
|
||||
patientDisplayAddress = "Musterstraße 1, 12345 Musterstadt",
|
||||
createdAt = LocalDate.of(2026, 8, 19),
|
||||
blocks = listOf(
|
||||
PdfExportBlock(
|
||||
title = "Wundgrund",
|
||||
items = listOf(PdfExportItem(label = "Granulation", isFreeText = false, freeTextValue = "")),
|
||||
),
|
||||
),
|
||||
signatures = (1..signatureCount).map { PdfExportSignature("Pfleger $it", "sig_$it.png") },
|
||||
photos = (1..photoCount).map { PdfExportPhoto("foto_$it.jpg") },
|
||||
)
|
||||
|
||||
private fun pageCount(file: File): Int =
|
||||
ParcelFileDescriptor.open(file, ParcelFileDescriptor.MODE_READ_ONLY).use { fd ->
|
||||
PdfRenderer(fd).use { it.pageCount }
|
||||
}
|
||||
|
||||
private fun tmpFiles(): List<File> = targetDir.listFiles().orEmpty().filter { it.name.endsWith(".tmp") }
|
||||
|
||||
// --- Normalfall als Referenz ---------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun erfolgreicher_export_erzeugt_ein_lesbares_pdf_ohne_temporaere_datei() = runDbTest {
|
||||
val result = exporter().export(model())
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
assertTrue(targetFile.exists())
|
||||
assertTrue(pageCount(targetFile) >= 1)
|
||||
assertTrue(tmpFiles().isEmpty())
|
||||
}
|
||||
|
||||
// --- Schreibfehler -------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun zielordner_ist_eine_datei_liefert_fehler_statt_absturz() = runDbTest {
|
||||
// Unter dem PDF-Wurzelordner liegt statt des Dokumentationsordners eine normale Datei.
|
||||
targetDir.deleteRecursively()
|
||||
targetDir.writeText("blockiert")
|
||||
|
||||
val result = exporter().export(model())
|
||||
|
||||
assertTrue("erwartet Failure, war $result", result is PdfExportResult.Failure)
|
||||
assertTrue((result as PdfExportResult.Failure).error is PdfExportError.WriteFailed)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fehler_beim_schreiben_laesst_ein_vorhandenes_pdf_unangetastet() = runDbTest {
|
||||
val first = exporter().export(model())
|
||||
assertTrue(first is PdfExportResult.Success)
|
||||
val sizeBefore = targetFile.length()
|
||||
assertTrue(sizeBefore > 0)
|
||||
|
||||
// Zweiter Export scheitert: am Pfad der temporären Datei steht ein Ordner.
|
||||
File(targetDir, "$fileName.tmp").mkdirs()
|
||||
val second = exporter().export(model(signatureCount = 1))
|
||||
|
||||
assertTrue("erwartet Failure, war $second", second is PdfExportResult.Failure)
|
||||
assertTrue("bisheriges PDF darf nicht verloren gehen", targetFile.exists())
|
||||
assertEquals(sizeBefore, targetFile.length())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun scheitert_das_umbenennen_bleibt_keine_halbfertige_tmp_datei_zurueck() = runDbTest {
|
||||
// Am endgültigen Pfad steht ein nicht-leerer Ordner: Löschen/Umbenennen schlagen fehl.
|
||||
targetFile.mkdirs()
|
||||
File(targetFile, "inhalt.txt").writeText("x")
|
||||
|
||||
val result = exporter().export(model())
|
||||
|
||||
assertTrue("erwartet Failure, war $result", result is PdfExportResult.Failure)
|
||||
assertTrue(tmpFiles().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun erneuter_export_nach_einem_fehler_funktioniert() = runDbTest {
|
||||
File(targetDir, "$fileName.tmp").mkdirs()
|
||||
assertTrue(exporter().export(model()) is PdfExportResult.Failure)
|
||||
|
||||
File(targetDir, "$fileName.tmp").deleteRecursively()
|
||||
val retry = exporter().export(model())
|
||||
|
||||
assertTrue("erwartet Success, war $retry", retry is PdfExportResult.Success)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun wiederholter_export_ersetzt_die_vorhandene_datei_statt_weitere_anzulegen() = runDbTest {
|
||||
exporter().export(model())
|
||||
exporter().export(model(signatureCount = 1))
|
||||
|
||||
assertEquals(listOf(fileName), targetDir.listFiles().orEmpty().map { it.name })
|
||||
}
|
||||
|
||||
// --- Fotos / Signaturen fehlen oder sind defekt --------------------------------------
|
||||
|
||||
@Test
|
||||
fun fehlende_fotodateien_fuehren_zu_hinweisseiten_statt_zum_abbruch() = runDbTest {
|
||||
// FakePhotoStorage.decodeFitted liefert null (= Datei fehlt/defekt).
|
||||
val result = exporter().export(model(photoCount = 3))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
// Kopfseite + je eine Seite pro (nicht ladbarem) Foto
|
||||
assertTrue("mindestens Kopfseite + 3 Fotoseiten", pageCount(targetFile) >= 4)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun foto_dekodierung_mit_out_of_memory_fuehrt_nicht_zum_absturz() = runDbTest {
|
||||
val oomStorage = object : PhotoStorage by FakePhotoStorage() {
|
||||
override suspend fun decodeFitted(
|
||||
documentationId: String,
|
||||
fileName: String,
|
||||
maxWidthPx: Int,
|
||||
maxHeightPx: Int,
|
||||
): Bitmap? = throw OutOfMemoryError("Test: zu wenig Speicher")
|
||||
}
|
||||
|
||||
val result = exporter(photoStorage = oomStorage).export(model(photoCount = 2))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
assertTrue("mindestens Kopfseite + 2 Fotoseiten", pageCount(targetFile) >= 3)
|
||||
assertTrue(tmpFiles().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun foto_dekodierung_mit_io_fehler_fuehrt_nicht_zum_abbruch() = runDbTest {
|
||||
val failing = object : PhotoStorage by FakePhotoStorage() {
|
||||
override suspend fun decodeFitted(
|
||||
documentationId: String,
|
||||
fileName: String,
|
||||
maxWidthPx: Int,
|
||||
maxHeightPx: Int,
|
||||
): Bitmap? = throw java.io.IOException("Test: Lesefehler")
|
||||
}
|
||||
|
||||
val result = exporter(photoStorage = failing).export(model(photoCount = 1))
|
||||
|
||||
assertTrue(result is PdfExportResult.Success)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fehlende_signaturdatei_fuehrt_zu_platzhalter_statt_zum_abbruch() = runDbTest {
|
||||
// FakeSignatureStorage.decode liefert standardmäßig null.
|
||||
val result = exporter().export(model(signatureCount = 2))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
assertTrue(pageCount(targetFile) >= 1)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun signatur_dekodierung_mit_exception_fuehrt_nicht_zum_abbruch() = runDbTest {
|
||||
val failing = object : SignatureStorage by FakeSignatureStorage() {
|
||||
override suspend fun decode(documentationId: String, fileName: String): Bitmap? =
|
||||
throw IllegalStateException("Test: defekte Signatur")
|
||||
}
|
||||
|
||||
val result = exporter(signatureStorage = failing).export(model(signatureCount = 1))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun grosser_export_mit_vielen_nicht_ladbaren_fotos_bleibt_stabil() = runDbTest {
|
||||
val result = exporter().export(model(photoCount = 40, signatureCount = 3))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfExportResult.Success)
|
||||
assertFalse(tmpFiles().isNotEmpty())
|
||||
assertTrue("mindestens Kopfseite + 40 Fotoseiten", pageCount(targetFile) >= 41)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,210 @@
|
||||
package de.medapp.wunddoku.pdf
|
||||
|
||||
import android.content.ActivityNotFoundException
|
||||
import android.content.Context
|
||||
import android.content.ContextWrapper
|
||||
import android.content.Intent
|
||||
import android.os.Bundle
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertNotEquals
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.util.UUID
|
||||
|
||||
/**
|
||||
* Fehlerpfade von [AndroidPdfOpener], [AndroidPdfSharer] und [AndroidPdfImageSharer]:
|
||||
* fehlende Datei, Datei außerhalb der FileProvider-Freigabe, keine passende App, verweigerter
|
||||
* Zugriff. Der Activity-Start wird über einen [ContextWrapper] abgefangen - es öffnet sich
|
||||
* dabei nie eine echte App.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class PdfIntentErrorHandlingTest {
|
||||
|
||||
private val baseContext: Context = InstrumentationRegistry.getInstrumentation().targetContext
|
||||
private val id = "test-${UUID.randomUUID()}"
|
||||
private lateinit var sharedPdf: File
|
||||
private lateinit var sharedImage: File
|
||||
private lateinit var unsharedFile: File
|
||||
|
||||
/** Fängt startActivity ab und wirft optional einen vorgegebenen Fehler. */
|
||||
private class InterceptingContext(base: Context, private val failure: Throwable?) : ContextWrapper(base) {
|
||||
val started = mutableListOf<Intent>()
|
||||
|
||||
override fun startActivity(intent: Intent) {
|
||||
started += intent
|
||||
failure?.let { throw it }
|
||||
}
|
||||
|
||||
override fun startActivity(intent: Intent, options: Bundle?) {
|
||||
started += intent
|
||||
failure?.let { throw it }
|
||||
}
|
||||
}
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
// Liegt in einem per file_paths.xml freigegebenen Ordner ("pdf/" bzw. "pdf_images/").
|
||||
sharedPdf = File(File(File(baseContext.filesDir, "pdf"), id), "test.pdf").apply {
|
||||
parentFile!!.mkdirs()
|
||||
writeBytes(byteArrayOf(1, 2, 3))
|
||||
}
|
||||
sharedImage = File(File(File(baseContext.filesDir, "pdf_images"), id), "seite_01.jpg").apply {
|
||||
parentFile!!.mkdirs()
|
||||
writeBytes(byteArrayOf(1, 2, 3))
|
||||
}
|
||||
// Liegt bewusst AUSSERHALB aller freigegebenen Ordner.
|
||||
unsharedFile = File(baseContext.cacheDir, "nicht_freigegeben_$id.pdf").apply { writeBytes(byteArrayOf(1)) }
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
File(File(baseContext.filesDir, "pdf"), id).deleteRecursively()
|
||||
File(File(baseContext.filesDir, "pdf_images"), id).deleteRecursively()
|
||||
unsharedFile.delete()
|
||||
}
|
||||
|
||||
// --- PdfOpener -----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun opener_meldet_fehlende_datei() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
val result = AndroidPdfOpener(context).open(File(baseContext.filesDir, "pdf/$id/weg.pdf"))
|
||||
|
||||
assertEquals(PdfOpenResult.Failure.FileNotFound, result)
|
||||
assertTrue(context.started.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun opener_meldet_datei_ausserhalb_der_freigegebenen_ordner() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
val result = AndroidPdfOpener(context).open(unsharedFile)
|
||||
|
||||
assertTrue("erwartet UriResolutionFailed, war $result", result is PdfOpenResult.Failure.UriResolutionFailed)
|
||||
assertTrue(context.started.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun opener_meldet_fehlenden_pdf_reader() {
|
||||
val context = InterceptingContext(baseContext, ActivityNotFoundException("kein Reader"))
|
||||
|
||||
val result = AndroidPdfOpener(context).open(sharedPdf)
|
||||
|
||||
assertEquals(PdfOpenResult.Failure.NoViewerAvailable, result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun opener_meldet_verweigerten_zugriff_als_unerwarteten_fehler() {
|
||||
val context = InterceptingContext(baseContext, SecurityException("verweigert"))
|
||||
|
||||
val result = AndroidPdfOpener(context).open(sharedPdf)
|
||||
|
||||
assertTrue("erwartet Unexpected, war $result", result is PdfOpenResult.Failure.Unexpected)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun opener_faengt_beliebige_laufzeitfehler_beim_start_ab() {
|
||||
val context = InterceptingContext(baseContext, IllegalStateException("kaputt"))
|
||||
|
||||
val result = AndroidPdfOpener(context).open(sharedPdf)
|
||||
|
||||
assertTrue("erwartet Unexpected, war $result", result is PdfOpenResult.Failure.Unexpected)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun opener_gibt_nur_leserechte_frei() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
val result = AndroidPdfOpener(context).open(sharedPdf)
|
||||
|
||||
assertEquals(PdfOpenResult.Success, result)
|
||||
val intent = context.started.single()
|
||||
assertEquals(Intent.ACTION_VIEW, intent.action)
|
||||
assertEquals("application/pdf", intent.type)
|
||||
assertNotEquals(0, intent.flags and Intent.FLAG_GRANT_READ_URI_PERMISSION)
|
||||
assertEquals(0, intent.flags and Intent.FLAG_GRANT_WRITE_URI_PERMISSION)
|
||||
}
|
||||
|
||||
// --- PdfSharer -----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun sharer_meldet_datei_ausserhalb_der_freigegebenen_ordner() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
val result = AndroidPdfSharer(context).share(unsharedFile)
|
||||
|
||||
assertTrue("erwartet UriResolutionFailed, war $result", result is PdfShareResult.Failure.UriResolutionFailed)
|
||||
assertTrue(context.started.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun sharer_meldet_fehlende_app_zum_versenden() {
|
||||
val context = InterceptingContext(baseContext, ActivityNotFoundException("keine App"))
|
||||
|
||||
assertEquals(PdfShareResult.Failure.NoAppAvailable, AndroidPdfSharer(context).share(sharedPdf))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun sharer_meldet_verweigerten_zugriff_und_sonstige_fehler() {
|
||||
assertTrue(
|
||||
AndroidPdfSharer(InterceptingContext(baseContext, SecurityException("x"))).share(sharedPdf)
|
||||
is PdfShareResult.Failure.Unexpected
|
||||
)
|
||||
assertTrue(
|
||||
AndroidPdfSharer(InterceptingContext(baseContext, RuntimeException("x"))).share(sharedPdf)
|
||||
is PdfShareResult.Failure.Unexpected
|
||||
)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun sharer_gibt_nur_leserechte_frei() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
assertEquals(PdfShareResult.Success, AndroidPdfSharer(context).share(sharedPdf))
|
||||
|
||||
@Suppress("DEPRECATION")
|
||||
val inner = context.started.single().getParcelableExtra<Intent>(Intent.EXTRA_INTENT)!!
|
||||
assertEquals(Intent.ACTION_SEND, inner.action)
|
||||
assertEquals("application/pdf", inner.type)
|
||||
assertEquals(0, inner.flags and Intent.FLAG_GRANT_WRITE_URI_PERMISSION)
|
||||
}
|
||||
|
||||
// --- PdfImageSharer ------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun image_sharer_meldet_leere_liste() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
assertEquals(PdfImageShareResult.Failure.NoImages, AndroidPdfImageSharer(context).share(emptyList()))
|
||||
assertTrue(context.started.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun image_sharer_meldet_unfreigegebene_datei_auch_wenn_nur_eine_von_mehreren_betroffen_ist() {
|
||||
val context = InterceptingContext(baseContext, null)
|
||||
|
||||
val result = AndroidPdfImageSharer(context).share(listOf(sharedImage, unsharedFile))
|
||||
|
||||
assertTrue("erwartet UriResolutionFailed, war $result", result is PdfImageShareResult.Failure.UriResolutionFailed)
|
||||
assertTrue(context.started.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun image_sharer_meldet_fehlende_app_und_verweigerten_zugriff() {
|
||||
assertEquals(
|
||||
PdfImageShareResult.Failure.NoAppAvailable,
|
||||
AndroidPdfImageSharer(InterceptingContext(baseContext, ActivityNotFoundException("x"))).share(listOf(sharedImage)),
|
||||
)
|
||||
assertTrue(
|
||||
AndroidPdfImageSharer(InterceptingContext(baseContext, SecurityException("x"))).share(listOf(sharedImage))
|
||||
is PdfImageShareResult.Failure.Unexpected
|
||||
)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,110 @@
|
||||
package de.medapp.wunddoku.pdf
|
||||
|
||||
import android.graphics.Paint
|
||||
import android.graphics.pdf.PdfDocument
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.io.FileOutputStream
|
||||
import java.util.UUID
|
||||
|
||||
/** Fehlerbehandlung von [AndroidPdfToImagesConverter] mit echten PDF-Dateien. */
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class PdfToImagesErrorHandlingTest {
|
||||
|
||||
private val context = InstrumentationRegistry.getInstrumentation().targetContext
|
||||
private val converter = AndroidPdfToImagesConverter(context)
|
||||
private val documentationId = "test-${UUID.randomUUID()}"
|
||||
private lateinit var workDir: File
|
||||
|
||||
private val imagesDir get() = File(File(context.filesDir, "pdf_images"), documentationId)
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
workDir = File(context.cacheDir, "errtest-${UUID.randomUUID()}").apply { mkdirs() }
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
imagesDir.deleteRecursively()
|
||||
workDir.deleteRecursively()
|
||||
}
|
||||
|
||||
private fun validPdf(pages: Int = 1): File {
|
||||
val file = File(workDir, "gueltig.pdf")
|
||||
val document = PdfDocument()
|
||||
repeat(pages) { index ->
|
||||
val page = document.startPage(PdfDocument.PageInfo.Builder(595, 842, index + 1).create())
|
||||
page.canvas.drawText("Seite ${index + 1}", 50f, 50f, Paint().apply { textSize = 20f })
|
||||
document.finishPage(page)
|
||||
}
|
||||
FileOutputStream(file).use { document.writeTo(it) }
|
||||
document.close()
|
||||
return file
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fehlende_pdf_liefert_file_not_found() = runDbTest {
|
||||
val result = converter.convert(documentationId, File(workDir, "gibt_es_nicht.pdf"))
|
||||
|
||||
assertEquals(PdfToImagesResult.Failure.FileNotFound, result)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun beschaedigte_pdf_liefert_fehler_statt_absturz_und_hinterlaesst_keine_bilder() = runDbTest {
|
||||
val corrupt = File(workDir, "defekt.pdf").apply { writeBytes(ByteArray(1024) { (it % 251).toByte() }) }
|
||||
|
||||
val result = converter.convert(documentationId, corrupt)
|
||||
|
||||
assertTrue("erwartet Failure, war $result", result is PdfToImagesResult.Failure)
|
||||
assertTrue(imagesDir.listFiles().orEmpty().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun leere_pdf_datei_liefert_fehler_statt_absturz() = runDbTest {
|
||||
val empty = File(workDir, "leer.pdf").apply { createNewFile() }
|
||||
|
||||
val result = converter.convert(documentationId, empty)
|
||||
|
||||
assertTrue("erwartet Failure, war $result", result is PdfToImagesResult.Failure)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun gueltige_pdf_wird_seitenweise_in_bilder_umgewandelt() = runDbTest {
|
||||
val result = converter.convert(documentationId, validPdf(pages = 2))
|
||||
|
||||
assertTrue("erwartet Success, war $result", result is PdfToImagesResult.Success)
|
||||
val files = (result as PdfToImagesResult.Success).imageFiles
|
||||
assertEquals(2, files.size)
|
||||
assertTrue(files.all { it.exists() && it.length() > 0 })
|
||||
}
|
||||
|
||||
@Test
|
||||
fun veraltete_bilder_eines_frueheren_exports_werden_entfernt() = runDbTest {
|
||||
imagesDir.mkdirs()
|
||||
val stale = File(imagesDir, "seite_09.jpg").apply { writeText("alt") }
|
||||
|
||||
val result = converter.convert(documentationId, validPdf(pages = 1))
|
||||
|
||||
assertTrue(result is PdfToImagesResult.Success)
|
||||
assertFalse("veraltete Seite darf nicht mitgeteilt werden", stale.exists())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun nach_einem_fehler_funktioniert_die_naechste_umwandlung() = runDbTest {
|
||||
val corrupt = File(workDir, "defekt.pdf").apply { writeBytes(ByteArray(64) { 1 }) }
|
||||
assertTrue(converter.convert(documentationId, corrupt) is PdfToImagesResult.Failure)
|
||||
|
||||
val result = converter.convert(documentationId, validPdf())
|
||||
|
||||
assertTrue(result is PdfToImagesResult.Success)
|
||||
}
|
||||
}
|
||||
+114
@@ -0,0 +1,114 @@
|
||||
package de.medapp.wunddoku.signature
|
||||
|
||||
import android.graphics.Bitmap
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import de.medapp.wunddoku.testutil.blankBitmap
|
||||
import de.medapp.wunddoku.testutil.expectThrowsSuspend
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import de.medapp.wunddoku.testutil.signatureBitmap
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotNull
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.util.UUID
|
||||
|
||||
/**
|
||||
* Fehlerbehandlung von [InternalSignatureStorage] mit echten Dateien (eigenes Test-
|
||||
* Wurzelverzeichnis, berührt keine echten Signaturen).
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class SignatureStorageErrorHandlingTest {
|
||||
|
||||
private val context = InstrumentationRegistry.getInstrumentation().targetContext
|
||||
private val rootDirName = "test_signatures_${UUID.randomUUID()}"
|
||||
private lateinit var storage: InternalSignatureStorage
|
||||
private val documentationId = "doc-1"
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
storage = InternalSignatureStorage(context, rootDirName)
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
File(context.filesDir, rootDirName).deleteRecursively()
|
||||
}
|
||||
|
||||
private fun filesInDocDir(): List<File> =
|
||||
File(File(context.filesDir, rootDirName), documentationId).listFiles()?.toList().orEmpty()
|
||||
|
||||
@Test
|
||||
fun speichern_einer_recycelten_bitmap_wirft_und_hinterlaesst_keine_datei() = runDbTest {
|
||||
val recycled = signatureBitmap().also { it.recycle() }
|
||||
|
||||
expectThrowsSuspend<Exception> { storage.save(documentationId, recycled) }
|
||||
|
||||
assertTrue("keine leere PNG-Datei als scheinbar gültige Signatur", filesInDocDir().isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun nach_fehlgeschlagenem_speichern_funktioniert_das_naechste_speichern() = runDbTest {
|
||||
val recycled = signatureBitmap().also { it.recycle() }
|
||||
expectThrowsSuspend<Exception> { storage.save(documentationId, recycled) }
|
||||
|
||||
val fileName = storage.save(documentationId, signatureBitmap())
|
||||
|
||||
assertTrue(storage.resolve(documentationId, fileName).exists())
|
||||
assertEquals(1, filesInDocDir().size)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun gespeicherte_signatur_laesst_sich_wieder_dekodieren() = runDbTest {
|
||||
val fileName = storage.save(documentationId, signatureBitmap())
|
||||
|
||||
val decoded = storage.decode(documentationId, fileName)
|
||||
|
||||
assertNotNull(decoded)
|
||||
assertEquals(40, decoded!!.width)
|
||||
decoded.recycle()
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decode_einer_fehlenden_datei_liefert_null() = runDbTest {
|
||||
assertNull(storage.decode(documentationId, "fehlt.png"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decode_einer_beschaedigten_datei_liefert_null_statt_abzustuerzen() = runDbTest {
|
||||
val target = storage.resolve(documentationId, "defekt.png")
|
||||
target.parentFile!!.mkdirs()
|
||||
target.writeBytes(ByteArray(256) { 3 })
|
||||
|
||||
assertNull(storage.decode(documentationId, "defekt.png"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun decode_einer_leeren_datei_liefert_null() = runDbTest {
|
||||
val target = storage.resolve(documentationId, "leer.png")
|
||||
target.parentFile!!.mkdirs()
|
||||
target.createNewFile()
|
||||
|
||||
assertNull(storage.decode(documentationId, "leer.png"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun loeschen_nicht_vorhandener_dateien_wirft_nicht() = runDbTest {
|
||||
storage.delete(documentationId, "gibt_es_nicht.png")
|
||||
storage.deleteAll(documentationId)
|
||||
assertFalse(File(File(context.filesDir, rootDirName), documentationId).exists())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun leere_zeichnung_wird_von_der_validierung_erkannt() {
|
||||
val blank: Bitmap = blankBitmap()
|
||||
assertTrue(SignatureBitmapValidation.isBlank(blank))
|
||||
assertFalse(SignatureBitmapValidation.isBlank(signatureBitmap()))
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,196 @@
|
||||
package de.medapp.wunddoku.testutil
|
||||
|
||||
import android.graphics.Bitmap
|
||||
import android.net.Uri
|
||||
import de.medapp.wunddoku.data.dao.CheckItemStateDao
|
||||
import de.medapp.wunddoku.data.dao.DocumentationDao
|
||||
import de.medapp.wunddoku.data.dao.PatientDao
|
||||
import de.medapp.wunddoku.data.entity.PatientEntity
|
||||
import de.medapp.wunddoku.data.entity.relations.DocumentationWithDetails
|
||||
import de.medapp.wunddoku.data.dao.PhotoDao
|
||||
import de.medapp.wunddoku.data.dao.SignatureDao
|
||||
import de.medapp.wunddoku.data.repository.DocumentationRepository
|
||||
import de.medapp.wunddoku.data.repository.WoundCarerRepository
|
||||
import de.medapp.wunddoku.media.PhotoStorage
|
||||
import de.medapp.wunddoku.pdf.DocumentationPdfExporter
|
||||
import de.medapp.wunddoku.pdf.PdfToImagesConverter
|
||||
import de.medapp.wunddoku.signature.SignatureStorage
|
||||
import kotlinx.coroutines.withTimeout
|
||||
import kotlinx.coroutines.delay
|
||||
import java.io.File
|
||||
|
||||
/**
|
||||
* Hilfsklassen für die Fehlerbehandlungs-Tests. Die bestehenden Fakes (Fakes.kt) bleiben
|
||||
* unverändert; hier werden sie per Delegation um gezielt auslösbare Fehler ergänzt.
|
||||
*/
|
||||
|
||||
/** [PhotoStorage] mit konfigurierbaren Fehlern pro Aufruf (1-basierte Aufrufnummer). */
|
||||
class FailingPhotoStorage(
|
||||
val delegate: FakePhotoStorage = FakePhotoStorage(),
|
||||
) : PhotoStorage by delegate {
|
||||
|
||||
/** Liefert für die n-te [importFrom]-Anweisung einen Fehler (oder `null` = Erfolg). */
|
||||
var importFailure: (Int) -> Throwable? = { null }
|
||||
private var importCalls = 0
|
||||
|
||||
override suspend fun importFrom(documentationId: String, sourceUri: Uri): String {
|
||||
importCalls++
|
||||
importFailure(importCalls)?.let { throw it }
|
||||
return delegate.importFrom(documentationId, sourceUri)
|
||||
}
|
||||
}
|
||||
|
||||
/** [SignatureStorage] mit gezielt auslösbarem Fehler beim Speichern. */
|
||||
class FailingSignatureStorage(
|
||||
val delegate: FakeSignatureStorage = FakeSignatureStorage(),
|
||||
) : SignatureStorage by delegate {
|
||||
|
||||
var saveFailure: Throwable? = null
|
||||
|
||||
override suspend fun save(documentationId: String, bitmap: Bitmap): String {
|
||||
saveFailure?.let { throw it }
|
||||
return delegate.save(documentationId, bitmap)
|
||||
}
|
||||
}
|
||||
|
||||
/** Exporter, der eine beliebige Exception/Error wirft (statt ein Failure-Ergebnis zu liefern). */
|
||||
class ThrowingPdfExporter(private val error: Throwable) : DocumentationPdfExporter {
|
||||
override suspend fun export(model: de.medapp.wunddoku.pdf.PdfExportModel): de.medapp.wunddoku.pdf.PdfExportResult =
|
||||
throw error
|
||||
}
|
||||
|
||||
/** Converter, der eine beliebige Exception/Error wirft. */
|
||||
class ThrowingPdfToImagesConverter(private val error: Throwable) : PdfToImagesConverter {
|
||||
override suspend fun convert(documentationId: String, pdfFile: File): de.medapp.wunddoku.pdf.PdfToImagesResult =
|
||||
throw error
|
||||
}
|
||||
|
||||
/** [CheckItemStateDao] mit abschaltbaren Schreibfehlern (z. B. "database or disk is full"). */
|
||||
class FailingCheckItemStateDao(
|
||||
private val delegate: CheckItemStateDao,
|
||||
) : CheckItemStateDao by delegate {
|
||||
|
||||
@Volatile var failure: Throwable? = null
|
||||
|
||||
override suspend fun setChecked(id: String, checked: Boolean) {
|
||||
failure?.let { throw it }
|
||||
delegate.setChecked(id, checked)
|
||||
}
|
||||
|
||||
override suspend fun updateFreeTextValue(id: String, value: String) {
|
||||
failure?.let { throw it }
|
||||
delegate.updateFreeTextValue(id, value)
|
||||
}
|
||||
}
|
||||
|
||||
/** [DocumentationDao] mit abschaltbarem Fehler beim Laden einer kompletten Dokumentation. */
|
||||
class FailingDocumentationDao(
|
||||
private val delegate: DocumentationDao,
|
||||
) : DocumentationDao by delegate {
|
||||
|
||||
@Volatile var loadFailure: Throwable? = null
|
||||
|
||||
override suspend fun getFullDocumentation(id: String): DocumentationWithDetails? {
|
||||
loadFailure?.let { throw it }
|
||||
return delegate.getFullDocumentation(id)
|
||||
}
|
||||
}
|
||||
|
||||
/** [PatientDao] mit abschaltbarem Fehler beim Einfügen. */
|
||||
class FailingPatientDao(
|
||||
private val delegate: PatientDao,
|
||||
) : PatientDao by delegate {
|
||||
|
||||
@Volatile var insertFailure: Throwable? = null
|
||||
|
||||
override suspend fun insert(patient: PatientEntity) {
|
||||
insertFailure?.let { throw it }
|
||||
delegate.insert(patient)
|
||||
}
|
||||
}
|
||||
|
||||
/** [PhotoDao] mit abschaltbarem Fehler beim Einfügen. */
|
||||
class FailingPhotoDao(
|
||||
private val delegate: PhotoDao,
|
||||
) : PhotoDao by delegate {
|
||||
|
||||
@Volatile var insertFailure: Throwable? = null
|
||||
|
||||
override suspend fun insert(photo: de.medapp.wunddoku.data.entity.PhotoEntity) {
|
||||
insertFailure?.let { throw it }
|
||||
delegate.insert(photo)
|
||||
}
|
||||
}
|
||||
|
||||
/** [SignatureDao] mit abschaltbarem Fehler beim Einfügen. */
|
||||
class FailingSignatureDao(
|
||||
private val delegate: SignatureDao,
|
||||
) : SignatureDao by delegate {
|
||||
|
||||
@Volatile var insertFailure: Throwable? = null
|
||||
|
||||
override suspend fun insert(signature: de.medapp.wunddoku.data.entity.SignatureEntity) {
|
||||
insertFailure?.let { throw it }
|
||||
delegate.insert(signature)
|
||||
}
|
||||
}
|
||||
|
||||
/** Baut ein [DocumentationRepository] auf der echten In-Memory-DB mit austauschbaren Bausteinen. */
|
||||
fun TestEnvironment.buildRepository(
|
||||
photoStorage: PhotoStorage = this.photoStorage,
|
||||
signatureStorage: SignatureStorage = this.signatureStorage,
|
||||
woundCarerRepository: WoundCarerRepository = this.woundCarerRepository,
|
||||
pdfExporter: DocumentationPdfExporter = this.pdfExporter,
|
||||
pdfToImagesConverter: PdfToImagesConverter = this.pdfToImagesConverter,
|
||||
checkItemStateDao: CheckItemStateDao = db.checkItemStateDao(),
|
||||
photoDao: PhotoDao = db.photoDao(),
|
||||
signatureDao: SignatureDao = db.signatureDao(),
|
||||
documentationDao: DocumentationDao = db.documentationDao(),
|
||||
): DocumentationRepository = DocumentationRepository(
|
||||
documentationDao = documentationDao,
|
||||
blockStateDao = db.blockStateDao(),
|
||||
checkItemStateDao = checkItemStateDao,
|
||||
photoDao = photoDao,
|
||||
signatureDao = signatureDao,
|
||||
patientDao = db.patientDao(),
|
||||
photoStorage = photoStorage,
|
||||
signatureStorage = signatureStorage,
|
||||
woundCarerRepository = woundCarerRepository,
|
||||
pdfExporter = pdfExporter,
|
||||
pdfToImagesConverter = pdfToImagesConverter,
|
||||
db = db,
|
||||
)
|
||||
|
||||
/** Erwartet, dass der Suspend-Block eine Exception vom Typ [T] wirft, und liefert sie zurück. */
|
||||
suspend inline fun <reified T : Throwable> expectThrowsSuspend(block: () -> Unit): T {
|
||||
try {
|
||||
block()
|
||||
} catch (e: Throwable) {
|
||||
if (e is T) return e
|
||||
throw e
|
||||
}
|
||||
throw AssertionError("Erwartet: ${T::class.java.simpleName}, es wurde aber keine Exception geworfen")
|
||||
}
|
||||
|
||||
/** Wartet (max. [timeoutMs]) bis [condition] wahr ist - für asynchrone ViewModel-Zustände. */
|
||||
suspend fun awaitCondition(timeoutMs: Long = 5_000, condition: () -> Boolean) {
|
||||
withTimeout(timeoutMs) {
|
||||
while (!condition()) delay(20)
|
||||
}
|
||||
}
|
||||
|
||||
/** Wie [awaitCondition], aber mit Suspend-Bedingung (z. B. Abfrage der Datenbank). */
|
||||
suspend fun awaitUntil(timeoutMs: Long = 5_000, condition: suspend () -> Boolean) {
|
||||
withTimeout(timeoutMs) {
|
||||
while (!condition()) delay(20)
|
||||
}
|
||||
}
|
||||
|
||||
/** Führt [block] auf dem Main-Thread aus (ViewModels greifen intern auf Main-State zu). */
|
||||
fun <T> onMain(block: () -> T): T {
|
||||
var result: Result<T>? = null
|
||||
androidx.test.platform.app.InstrumentationRegistry.getInstrumentation().runOnMainSync {
|
||||
result = runCatching(block)
|
||||
}
|
||||
return result!!.getOrThrow()
|
||||
}
|
||||
+473
@@ -0,0 +1,473 @@
|
||||
package de.medapp.wunddoku.ui.documentation.edit
|
||||
|
||||
import android.database.sqlite.SQLiteFullException
|
||||
import android.net.Uri
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import de.medapp.wunddoku.data.repository.DocumentationRepository
|
||||
import de.medapp.wunddoku.domain.model.CheckItem
|
||||
import de.medapp.wunddoku.pdf.PdfExportError
|
||||
import de.medapp.wunddoku.pdf.PdfExportResult
|
||||
import de.medapp.wunddoku.pdf.PdfToImagesResult
|
||||
import de.medapp.wunddoku.testutil.FailingCheckItemStateDao
|
||||
import de.medapp.wunddoku.testutil.FailingDocumentationDao
|
||||
import de.medapp.wunddoku.testutil.FailingPhotoStorage
|
||||
import de.medapp.wunddoku.testutil.FailingSignatureStorage
|
||||
import de.medapp.wunddoku.testutil.TestEnvironment
|
||||
import de.medapp.wunddoku.testutil.ThrowingPdfExporter
|
||||
import de.medapp.wunddoku.testutil.awaitCondition
|
||||
import de.medapp.wunddoku.testutil.awaitUntil
|
||||
import de.medapp.wunddoku.testutil.blankBitmap
|
||||
import de.medapp.wunddoku.testutil.buildRepository
|
||||
import de.medapp.wunddoku.testutil.firstPlainItem
|
||||
import de.medapp.wunddoku.testutil.onMain
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import de.medapp.wunddoku.testutil.signatureBitmap
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotNull
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import java.io.File
|
||||
import java.io.IOException
|
||||
|
||||
/**
|
||||
* Fehlerbehandlung im [DocumentationEditViewModel] mit echter In-Memory-Room-DB: Autosave bei
|
||||
* vollem Speicher (Datenverlust verhindern), Fotoimport (defekte Bilder, Speichermangel),
|
||||
* Signatur, PDF-Export und Teilen. Kein Fehler darf einen Absturz oder einen dauerhaft
|
||||
* hängenden Ladezustand verursachen.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class DocumentationEditViewModelErrorHandlingTest {
|
||||
|
||||
private lateinit var env: TestEnvironment
|
||||
private lateinit var documentationId: String
|
||||
private val someUri: Uri = Uri.parse("content://test/bild/1")
|
||||
|
||||
@Before
|
||||
fun setUp() = runDbTest {
|
||||
env = TestEnvironment()
|
||||
env.insertPatient()
|
||||
documentationId = env.documentationRepository.createEmpty("patient-1").id
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
env.close()
|
||||
}
|
||||
|
||||
private suspend fun createViewModel(
|
||||
repository: DocumentationRepository = env.documentationRepository,
|
||||
id: String = documentationId,
|
||||
): DocumentationEditViewModel {
|
||||
val viewModel = onMain { DocumentationEditViewModel(id, repository, env.woundCarerRepository) }
|
||||
awaitCondition { !viewModel.uiState.value.isLoading }
|
||||
return viewModel
|
||||
}
|
||||
|
||||
private fun DocumentationEditViewModel.plainItem(): CheckItem =
|
||||
uiState.value.documentation!!.blocks.first().firstPlainItem()
|
||||
|
||||
private fun DocumentationEditViewModel.freeTextItem(): CheckItem =
|
||||
uiState.value.documentation!!.blocks.first().items.first { it.isFreeText }
|
||||
|
||||
private fun DocumentationEditViewModel.itemById(id: String): CheckItem =
|
||||
uiState.value.documentation!!.blocks.flatMap { it.items }.first { it.checkItemStateId == id }
|
||||
|
||||
private suspend fun storedFreeText(itemId: String): String? =
|
||||
env.documentationRepository.getFullDocumentation(documentationId)
|
||||
?.blocks?.flatMap { it.items }?.firstOrNull { it.checkItemStateId == itemId }?.freeTextValue
|
||||
|
||||
// --- Laden ---------------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun unbekannte_dokumentation_zeigt_fehler_und_laedt_nicht_endlos() = runDbTest {
|
||||
val viewModel = createViewModel(id = "gibt-es-nicht")
|
||||
|
||||
assertEquals("Dokumentation nicht gefunden.", viewModel.uiState.value.error)
|
||||
assertFalse(viewModel.uiState.value.isLoading)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun datenbankfehler_beim_laden_zeigt_fehler_statt_dauerhaftem_ladezustand() = runDbTest {
|
||||
val failingDao = FailingDocumentationDao(env.db.documentationDao())
|
||||
.apply { loadFailure = IllegalStateException("Datenbank nicht verfügbar (Test)") }
|
||||
val repository = env.buildRepository(documentationDao = failingDao)
|
||||
|
||||
val viewModel = createViewModel(repository)
|
||||
|
||||
assertFalse(viewModel.uiState.value.isLoading)
|
||||
assertNotNull(viewModel.uiState.value.error)
|
||||
assertNull(viewModel.uiState.value.documentation)
|
||||
}
|
||||
|
||||
// --- Autosave: Haken -----------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun haken_wird_bei_normalem_betrieb_gespeichert() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
val item = viewModel.plainItem()
|
||||
|
||||
onMain { viewModel.onCheckedChanged(item.checkItemStateId, true) }
|
||||
|
||||
awaitUntil {
|
||||
env.documentationRepository.getFullDocumentation(documentationId)!!
|
||||
.blocks.flatMap { it.items }.first { it.checkItemStateId == item.checkItemStateId }.checked
|
||||
}
|
||||
assertNull(viewModel.uiState.value.saveError)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun haken_bei_vollem_speicher_meldet_fehler_und_zeigt_den_tatsaechlich_gespeicherten_stand() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao())
|
||||
.apply { failure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
val item = viewModel.plainItem()
|
||||
|
||||
onMain { viewModel.onCheckedChanged(item.checkItemStateId, true) }
|
||||
|
||||
awaitCondition {
|
||||
viewModel.uiState.value.saveError != null && !viewModel.itemById(item.checkItemStateId).checked
|
||||
}
|
||||
assertTrue(viewModel.uiState.value.saveError!!.contains("Speicherplatz"))
|
||||
assertFalse("Anzeige darf keinen nicht gespeicherten Haken zeigen", viewModel.itemById(item.checkItemStateId).checked)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speicherfehler_beim_haken_laesst_die_app_nicht_abstuerzen_und_spaetere_aenderungen_funktionieren() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao())
|
||||
.apply { failure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
val item = viewModel.plainItem()
|
||||
onMain { viewModel.onCheckedChanged(item.checkItemStateId, true) }
|
||||
awaitCondition { viewModel.uiState.value.saveError != null }
|
||||
onMain { viewModel.dismissSaveError() }
|
||||
|
||||
failingDao.failure = null
|
||||
onMain { viewModel.onCheckedChanged(item.checkItemStateId, true) }
|
||||
|
||||
awaitUntil {
|
||||
env.documentationRepository.getFullDocumentation(documentationId)!!
|
||||
.blocks.flatMap { it.items }.first { it.checkItemStateId == item.checkItemStateId }.checked
|
||||
}
|
||||
assertNull(viewModel.uiState.value.saveError)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun dismissSaveError_leert_die_meldung() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao()).apply { failure = IOException("x") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
onMain { viewModel.onCheckedChanged(viewModel.plainItem().checkItemStateId, true) }
|
||||
awaitCondition { viewModel.uiState.value.saveError != null }
|
||||
|
||||
onMain { viewModel.dismissSaveError() }
|
||||
|
||||
assertNull(viewModel.uiState.value.saveError)
|
||||
}
|
||||
|
||||
// --- Autosave: Freitext (Datenverlust verhindern) ------------------------------------
|
||||
|
||||
@Test
|
||||
fun freitext_wird_nach_debounce_gespeichert() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
val item = viewModel.freeTextItem()
|
||||
|
||||
onMain { viewModel.onFreeTextChanged(item.checkItemStateId, "Wunde trocken") }
|
||||
|
||||
awaitUntil { storedFreeText(item.checkItemStateId) == "Wunde trocken" }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun freitext_bleibt_bei_speicherfehler_in_der_anzeige_erhalten_und_wird_spaeter_nachgeschrieben() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao())
|
||||
.apply { failure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
val item = viewModel.freeTextItem()
|
||||
|
||||
onMain { viewModel.onFreeTextChanged(item.checkItemStateId, "Wichtiger Befund") }
|
||||
awaitCondition { viewModel.uiState.value.saveError != null }
|
||||
|
||||
assertEquals(
|
||||
"Der Nutzer darf seinen Text nicht verlieren",
|
||||
"Wichtiger Befund",
|
||||
viewModel.itemById(item.checkItemStateId).freeTextValue,
|
||||
)
|
||||
assertEquals("", storedFreeText(item.checkItemStateId))
|
||||
|
||||
// Speicher wieder verfügbar: der ON_STOP-Flush schreibt den bisher nicht gespeicherten Text.
|
||||
failingDao.failure = null
|
||||
onMain { viewModel.flushPendingChanges() }
|
||||
|
||||
awaitUntil { storedFreeText(item.checkItemStateId) == "Wichtiger Befund" }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun flush_bei_weiterhin_vollem_speicher_verwirft_den_text_nicht() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao())
|
||||
.apply { failure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
val item = viewModel.freeTextItem()
|
||||
onMain { viewModel.onFreeTextChanged(item.checkItemStateId, "Text") }
|
||||
onMain { viewModel.flushPendingChanges() }
|
||||
awaitCondition { viewModel.uiState.value.saveError != null }
|
||||
onMain { viewModel.dismissSaveError() }
|
||||
|
||||
// Zweiter Flush nach erfolgreicher Freigabe von Speicher: der Text muss noch vorhanden sein.
|
||||
failingDao.failure = null
|
||||
onMain { viewModel.flushPendingChanges() }
|
||||
|
||||
awaitUntil { storedFreeText(item.checkItemStateId) == "Text" }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speicherfehler_beendet_den_freitext_autosave_nicht_dauerhaft() = runDbTest {
|
||||
val failingDao = FailingCheckItemStateDao(env.db.checkItemStateDao())
|
||||
.apply { failure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(env.buildRepository(checkItemStateDao = failingDao))
|
||||
val item = viewModel.freeTextItem()
|
||||
onMain { viewModel.onFreeTextChanged(item.checkItemStateId, "Erster Versuch") }
|
||||
awaitCondition { viewModel.uiState.value.saveError != null }
|
||||
|
||||
failingDao.failure = null
|
||||
onMain { viewModel.onFreeTextChanged(item.checkItemStateId, "Zweiter Versuch") }
|
||||
|
||||
awaitUntil { storedFreeText(item.checkItemStateId) == "Zweiter Versuch" }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun flush_ohne_ausstehende_aenderungen_tut_nichts() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.flushPendingChanges() }
|
||||
|
||||
assertNull(viewModel.uiState.value.saveError)
|
||||
}
|
||||
|
||||
// --- Fotoimport ----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun foto_import_bei_defekten_bildern_meldet_fehler_und_beendet_den_ladezustand() = runDbTest {
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { IOException("Bild defekt (Test)") } }
|
||||
val viewModel = createViewModel(env.buildRepository(photoStorage = storage))
|
||||
|
||||
onMain { viewModel.onPhotosPicked(listOf(someUri, someUri)) }
|
||||
awaitCondition { viewModel.uiState.value.photoImportError != null && !viewModel.uiState.value.photoImportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.photoImportError!!.startsWith("2 von 2"))
|
||||
assertTrue(viewModel.uiState.value.documentation!!.photos.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun foto_import_uebernimmt_gueltige_bilder_auch_wenn_ein_bild_fehlschlaegt() = runDbTest {
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { call -> if (call == 2) IOException("defekt") else null } }
|
||||
val viewModel = createViewModel(env.buildRepository(photoStorage = storage))
|
||||
|
||||
onMain { viewModel.onPhotosPicked(listOf(someUri, someUri, someUri)) }
|
||||
awaitCondition { viewModel.uiState.value.photoImportError != null && !viewModel.uiState.value.photoImportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.photoImportError!!.startsWith("1 von 3"))
|
||||
assertEquals(2, viewModel.uiState.value.documentation!!.photos.size)
|
||||
assertEquals(2, env.db.photoDao().getForDocumentation(documentationId).size)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun foto_import_bei_arbeitsspeichermangel_stuerzt_nicht_ab_und_nennt_den_grund() = runDbTest {
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { OutOfMemoryError("Test") } }
|
||||
val viewModel = createViewModel(env.buildRepository(photoStorage = storage))
|
||||
|
||||
onMain { viewModel.onPhotosPicked(listOf(someUri)) }
|
||||
awaitCondition { viewModel.uiState.value.photoImportError != null && !viewModel.uiState.value.photoImportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.photoImportError!!.contains("Arbeitsspeicher"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun foto_import_bei_vollem_geraetespeicher_nennt_den_grund() = runDbTest {
|
||||
val storage = FailingPhotoStorage().apply {
|
||||
importFailure = { IOException("write failed: ENOSPC (No space left on device)") }
|
||||
}
|
||||
val viewModel = createViewModel(env.buildRepository(photoStorage = storage))
|
||||
|
||||
onMain { viewModel.onPhotosPicked(listOf(someUri)) }
|
||||
awaitCondition { viewModel.uiState.value.photoImportError != null && !viewModel.uiState.value.photoImportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.photoImportError!!.contains("Speicherplatz"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun kamera_aufraeumen_laeuft_auch_wenn_der_import_fehlschlaegt() = runDbTest {
|
||||
val storage = FailingPhotoStorage().apply { importFailure = { IOException("defekt") } }
|
||||
val viewModel = createViewModel(env.buildRepository(photoStorage = storage))
|
||||
val cleanedUp = java.util.concurrent.atomic.AtomicBoolean(false)
|
||||
|
||||
onMain { viewModel.onCameraPhotoCaptured(someUri) { cleanedUp.set(true) } }
|
||||
awaitCondition { cleanedUp.get() && !viewModel.uiState.value.photoImportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.photoImportError != null)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun leere_auswahl_ist_kein_fehler() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.onPhotosPicked(emptyList()) }
|
||||
|
||||
assertNull(viewModel.uiState.value.photoImportError)
|
||||
assertFalse(viewModel.uiState.value.photoImportInProgress)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fehlende_kamera_app_wird_gemeldet() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.onCameraUnavailable() }
|
||||
|
||||
assertNotNull(viewModel.uiState.value.photoImportError)
|
||||
}
|
||||
|
||||
// --- Signatur ------------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun signatur_bei_dateifehler_zeigt_meldung_und_laesst_den_dialog_offen() = runDbTest {
|
||||
val storage = FailingSignatureStorage().apply { saveFailure = IOException("defekt (Test)") }
|
||||
val viewModel = createViewModel(env.buildRepository(signatureStorage = storage))
|
||||
onMain { viewModel.requestAddSignature() }
|
||||
|
||||
onMain { viewModel.saveSignature("Pfleger Paul", signatureBitmap()) }
|
||||
awaitCondition { viewModel.uiState.value.signatureError != null }
|
||||
|
||||
assertTrue(viewModel.uiState.value.showAddSignatureDialog)
|
||||
assertTrue(viewModel.uiState.value.documentation!!.signatures.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun signatur_bei_vollem_speicher_nennt_den_grund() = runDbTest {
|
||||
val storage = FailingSignatureStorage().apply {
|
||||
saveFailure = IOException("write failed: ENOSPC (No space left on device)")
|
||||
}
|
||||
val viewModel = createViewModel(env.buildRepository(signatureStorage = storage))
|
||||
|
||||
onMain { viewModel.saveSignature("Pfleger Paul", signatureBitmap()) }
|
||||
awaitCondition { viewModel.uiState.value.signatureError != null }
|
||||
|
||||
assertTrue(viewModel.uiState.value.signatureError!!.contains("Speicherplatz"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun signatur_bei_arbeitsspeichermangel_stuerzt_nicht_ab() = runDbTest {
|
||||
val storage = FailingSignatureStorage().apply { saveFailure = OutOfMemoryError("Test") }
|
||||
val viewModel = createViewModel(env.buildRepository(signatureStorage = storage))
|
||||
|
||||
onMain { viewModel.saveSignature("Pfleger Paul", signatureBitmap()) }
|
||||
awaitCondition { viewModel.uiState.value.signatureError != null }
|
||||
|
||||
assertTrue(viewModel.uiState.value.signatureError!!.contains("Arbeitsspeicher"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun leere_signatur_wird_mit_fachlicher_meldung_abgelehnt() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.saveSignature("Pfleger Paul", blankBitmap()) }
|
||||
awaitCondition { viewModel.uiState.value.signatureError != null }
|
||||
|
||||
assertTrue(viewModel.uiState.value.documentation!!.signatures.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun signatur_ohne_namen_wird_abgelehnt() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.saveSignature(" ", signatureBitmap()) }
|
||||
awaitCondition { viewModel.uiState.value.signatureError != null }
|
||||
|
||||
assertTrue(viewModel.uiState.value.documentation!!.signatures.isEmpty())
|
||||
}
|
||||
|
||||
// --- PDF-Export ----------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun pdf_export_fehler_beendet_ladezustand_und_bietet_kein_anzeigen_an() = runDbTest {
|
||||
env.pdfExporter.result = { PdfExportResult.Failure(PdfExportError.WriteFailed("x")) }
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.exportPdf() }
|
||||
awaitCondition { viewModel.uiState.value.pdfExportMessage != null && !viewModel.uiState.value.pdfExportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.pdfExportMessage!!.contains("fehlgeschlagen"))
|
||||
assertNull(viewModel.uiState.value.lastExportedPdfFile)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun pdf_export_mit_speichermangel_im_exporter_haengt_nicht_und_stuerzt_nicht_ab() = runDbTest {
|
||||
val repository = env.buildRepository(pdfExporter = ThrowingPdfExporter(OutOfMemoryError("Test")))
|
||||
val viewModel = createViewModel(repository)
|
||||
|
||||
onMain { viewModel.exportPdf() }
|
||||
awaitCondition { viewModel.uiState.value.pdfExportMessage != null && !viewModel.uiState.value.pdfExportInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.pdfExportMessage!!.contains("Arbeitsspeicher"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun pdf_export_erfolg_stellt_die_datei_bereit() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.exportPdf() }
|
||||
awaitCondition { viewModel.uiState.value.lastExportedPdfFile != null && !viewModel.uiState.value.pdfExportInProgress }
|
||||
|
||||
assertNotNull(viewModel.uiState.value.lastExportedPdfFile)
|
||||
}
|
||||
|
||||
// --- Teilen --------------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun teilen_als_pdf_bei_vollem_speicher_zeigt_meldung_und_teilt_nichts() = runDbTest {
|
||||
env.pdfExporter.result = { PdfExportResult.Failure(PdfExportError.InsufficientStorage) }
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.shareAsPdf() }
|
||||
awaitCondition { viewModel.uiState.value.shareMessage != null && !viewModel.uiState.value.shareInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.shareMessage!!.contains("Speicherplatz"))
|
||||
assertNull(viewModel.uiState.value.pdfToShare)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun teilen_als_bilder_bei_konvertierungsfehler_zeigt_meldung_und_teilt_nichts() = runDbTest {
|
||||
env.pdfToImagesConverter.result = PdfToImagesResult.Failure.OutOfMemory
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.shareAsImages() }
|
||||
awaitCondition { viewModel.uiState.value.shareMessage != null && !viewModel.uiState.value.shareInProgress }
|
||||
|
||||
assertTrue(viewModel.uiState.value.shareMessage!!.startsWith("Bildexport fehlgeschlagen"))
|
||||
assertNull(viewModel.uiState.value.imagesToShare)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun teilen_als_bilder_bei_export_fehler_ueberspringt_die_konvertierung() = runDbTest {
|
||||
env.pdfExporter.result = { PdfExportResult.Failure(PdfExportError.OutOfMemory) }
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.shareAsImages() }
|
||||
awaitCondition { viewModel.uiState.value.shareMessage != null && !viewModel.uiState.value.shareInProgress }
|
||||
|
||||
assertTrue(env.pdfToImagesConverter.calls.isEmpty())
|
||||
assertNull(viewModel.uiState.value.imagesToShare)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun teilen_als_pdf_erfolg_stellt_die_datei_bereit() = runDbTest {
|
||||
val viewModel = createViewModel()
|
||||
|
||||
onMain { viewModel.shareAsPdf() }
|
||||
awaitCondition { viewModel.uiState.value.pdfToShare != null && !viewModel.uiState.value.shareInProgress }
|
||||
|
||||
assertNull(viewModel.uiState.value.shareMessage)
|
||||
assertTrue(viewModel.uiState.value.pdfToShare is File)
|
||||
}
|
||||
}
|
||||
+151
@@ -0,0 +1,151 @@
|
||||
package de.medapp.wunddoku.ui.patients.form
|
||||
|
||||
import android.database.sqlite.SQLiteFullException
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import de.medapp.wunddoku.data.repository.PatientRepository
|
||||
import de.medapp.wunddoku.testutil.FailingDocumentationDao
|
||||
import de.medapp.wunddoku.testutil.FailingPatientDao
|
||||
import de.medapp.wunddoku.testutil.TestEnvironment
|
||||
import de.medapp.wunddoku.testutil.awaitCondition
|
||||
import de.medapp.wunddoku.testutil.buildRepository
|
||||
import de.medapp.wunddoku.testutil.onMain
|
||||
import de.medapp.wunddoku.testutil.runDbTest
|
||||
import org.junit.After
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotNull
|
||||
import org.junit.Assert.assertNull
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
|
||||
/**
|
||||
* Fehlerbehandlung beim Speichern im [PatientFormViewModel]: voller Speicher/Datenbankfehler
|
||||
* dürfen weder abstürzen noch zu einer scheinbar erfolgreichen Navigation führen, und die
|
||||
* Eingaben des Nutzers bleiben im Formular erhalten.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class PatientFormViewModelErrorHandlingTest {
|
||||
|
||||
private lateinit var env: TestEnvironment
|
||||
|
||||
@Before
|
||||
fun setUp() {
|
||||
env = TestEnvironment()
|
||||
}
|
||||
|
||||
@After
|
||||
fun tearDown() {
|
||||
env.close()
|
||||
}
|
||||
|
||||
private fun fill(viewModel: PatientFormViewModel) = onMain {
|
||||
viewModel.onFirstNameChanged("Max")
|
||||
viewModel.onLastNameChanged("Mustermann")
|
||||
viewModel.onBirthDateDigitsChanged("14031980")
|
||||
viewModel.onStreetChanged("Musterstraße 1")
|
||||
viewModel.onPostalCodeChanged("12345")
|
||||
viewModel.onCityChanged("Musterstadt")
|
||||
viewModel.onPhone1Changed("0123456789")
|
||||
}
|
||||
|
||||
private suspend fun createViewModel(
|
||||
patientRepository: PatientRepository,
|
||||
startsNewDocumentation: Boolean,
|
||||
documentationDao: FailingDocumentationDao? = null,
|
||||
): PatientFormViewModel {
|
||||
val documentationRepository = if (documentationDao != null) {
|
||||
env.buildRepository(documentationDao = documentationDao)
|
||||
} else {
|
||||
env.documentationRepository
|
||||
}
|
||||
val viewModel = onMain {
|
||||
PatientFormViewModel(
|
||||
patientId = null,
|
||||
startsNewDocumentation = startsNewDocumentation,
|
||||
repository = patientRepository,
|
||||
documentationRepository = documentationRepository,
|
||||
)
|
||||
}
|
||||
awaitCondition { !viewModel.uiState.value.isLoading }
|
||||
return viewModel
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speicherfehler_beim_anlegen_des_patienten_zeigt_meldung_und_behaelt_die_eingaben() = runDbTest {
|
||||
val failingDao = FailingPatientDao(env.db.patientDao())
|
||||
.apply { insertFailure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(PatientRepository(failingDao), startsNewDocumentation = true)
|
||||
fill(viewModel)
|
||||
|
||||
onMain { viewModel.save() }
|
||||
awaitCondition { viewModel.uiState.value.validationError != null }
|
||||
|
||||
val state = viewModel.uiState.value
|
||||
assertTrue(state.validationError!!.contains("Speicherplatz"))
|
||||
assertFalse(state.patientSaved)
|
||||
assertNull(state.createdDocumentationId)
|
||||
assertEquals("Max", state.firstName)
|
||||
assertEquals("Mustermann", state.lastName)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun sonstiger_datenbankfehler_beim_speichern_stuerzt_nicht_ab() = runDbTest {
|
||||
val failingDao = FailingPatientDao(env.db.patientDao())
|
||||
.apply { insertFailure = IllegalStateException("Test") }
|
||||
val viewModel = createViewModel(PatientRepository(failingDao), startsNewDocumentation = false)
|
||||
fill(viewModel)
|
||||
|
||||
onMain { viewModel.save() }
|
||||
awaitCondition { viewModel.uiState.value.validationError != null }
|
||||
|
||||
assertFalse(viewModel.uiState.value.patientSaved)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun fehler_beim_anlegen_der_dokumentation_meldet_fehler_ohne_navigation() = runDbTest {
|
||||
val failingDocDao = FailingDocumentationDao(env.db.documentationDao())
|
||||
.apply { loadFailure = SQLiteFullException("database or disk is full") }
|
||||
val viewModel = createViewModel(
|
||||
env.patientRepository,
|
||||
startsNewDocumentation = true,
|
||||
documentationDao = failingDocDao,
|
||||
)
|
||||
fill(viewModel)
|
||||
|
||||
onMain { viewModel.save() }
|
||||
awaitCondition { viewModel.uiState.value.validationError != null }
|
||||
|
||||
assertNull("keine Navigation zu einer nicht angelegten Dokumentation", viewModel.uiState.value.createdDocumentationId)
|
||||
assertNotNull(viewModel.uiState.value.validationError)
|
||||
// Die Dokumentation wurde per Transaktion zurückgerollt: es gibt keine halbe Dokumentation.
|
||||
assertEquals(0, env.db.documentationDao().countForPatient(env.db.patientDao().findExisting("Max", "Mustermann", "1980-03-14")!!.id))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speichern_funktioniert_nach_einem_fehler_erneut() = runDbTest {
|
||||
val failingDao = FailingPatientDao(env.db.patientDao())
|
||||
.apply { insertFailure = IllegalStateException("Test") }
|
||||
val viewModel = createViewModel(PatientRepository(failingDao), startsNewDocumentation = false)
|
||||
fill(viewModel)
|
||||
onMain { viewModel.save() }
|
||||
awaitCondition { viewModel.uiState.value.validationError != null }
|
||||
|
||||
failingDao.insertFailure = null
|
||||
onMain { viewModel.save() }
|
||||
awaitCondition { viewModel.uiState.value.patientSaved }
|
||||
|
||||
assertNull(viewModel.uiState.value.validationError)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun ungueltige_eingaben_werden_weiterhin_fachlich_abgelehnt() = runDbTest {
|
||||
val viewModel = createViewModel(env.patientRepository, startsNewDocumentation = false)
|
||||
|
||||
onMain { viewModel.save() }
|
||||
|
||||
assertNotNull(viewModel.uiState.value.validationError)
|
||||
assertFalse(viewModel.uiState.value.patientSaved)
|
||||
}
|
||||
}
|
||||
@@ -18,6 +18,8 @@ import de.medapp.wunddoku.data.entity.SignatureEntity
|
||||
import de.medapp.wunddoku.data.mapper.toDomain
|
||||
import de.medapp.wunddoku.data.mapper.toSummary
|
||||
import de.medapp.wunddoku.domain.catalog.DocumentationCatalog
|
||||
import de.medapp.wunddoku.domain.error.FailureCategory
|
||||
import de.medapp.wunddoku.domain.error.runCatchingCancellable
|
||||
import de.medapp.wunddoku.domain.model.Documentation
|
||||
import de.medapp.wunddoku.domain.model.DocumentationStatus
|
||||
import de.medapp.wunddoku.domain.model.DocumentationSummary
|
||||
@@ -34,6 +36,7 @@ import de.medapp.wunddoku.pdf.PdfToImagesConverter
|
||||
import de.medapp.wunddoku.pdf.PdfToImagesResult
|
||||
import de.medapp.wunddoku.signature.SignatureBitmapValidation
|
||||
import de.medapp.wunddoku.signature.SignatureStorage
|
||||
import kotlinx.coroutines.CancellationException
|
||||
import kotlinx.coroutines.flow.Flow
|
||||
import kotlinx.coroutines.flow.map
|
||||
import java.io.File
|
||||
@@ -201,21 +204,29 @@ class DocumentationRepository(
|
||||
// Unterschriften werden bewusst NICHT kopiert (siehe Doc-Kommentar oben).
|
||||
|
||||
if (copyPhotos) {
|
||||
for (sourcePhoto in source.photos) {
|
||||
val copiedFileName = photoStorage.duplicate(
|
||||
sourceDocumentationId = source.documentation.id,
|
||||
sourceFileName = sourcePhoto.fileName,
|
||||
targetDocumentationId = newDocumentationId,
|
||||
)
|
||||
photoDao.insert(
|
||||
PhotoEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = newDocumentationId,
|
||||
fileName = copiedFileName,
|
||||
orderIndex = sourcePhoto.orderIndex,
|
||||
createdAt = now,
|
||||
try {
|
||||
for (sourcePhoto in source.photos) {
|
||||
val copiedFileName = photoStorage.duplicate(
|
||||
sourceDocumentationId = source.documentation.id,
|
||||
sourceFileName = sourcePhoto.fileName,
|
||||
targetDocumentationId = newDocumentationId,
|
||||
)
|
||||
)
|
||||
photoDao.insert(
|
||||
PhotoEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = newDocumentationId,
|
||||
fileName = copiedFileName,
|
||||
orderIndex = sourcePhoto.orderIndex,
|
||||
createdAt = now,
|
||||
)
|
||||
)
|
||||
}
|
||||
} catch (e: Throwable) {
|
||||
// Die Room-Transaktion rollt die DB-Zeilen zurück - bereits kopierte Fotodateien
|
||||
// der nie entstandenen Dokumentation würden aber verwaist im Speicher bleiben
|
||||
// (bei Speichermangel besonders ärgerlich). Aufräumen, dann Fehler weiterreichen.
|
||||
runCatching { photoStorage.deleteAll(newDocumentationId) }
|
||||
throw e
|
||||
}
|
||||
}
|
||||
|
||||
@@ -250,16 +261,22 @@ class DocumentationRepository(
|
||||
|
||||
suspend fun addPhoto(documentationId: String, sourceUri: Uri): Photo {
|
||||
val fileName = photoStorage.importFrom(documentationId, sourceUri)
|
||||
val nextOrder = photoDao.getMaxOrderIndex(documentationId) + 1
|
||||
val now = Instant.now()
|
||||
val entity = PhotoEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = documentationId,
|
||||
fileName = fileName,
|
||||
orderIndex = nextOrder,
|
||||
createdAt = now.toEpochMilli(),
|
||||
)
|
||||
photoDao.insert(entity)
|
||||
val entity = try {
|
||||
val nextOrder = photoDao.getMaxOrderIndex(documentationId) + 1
|
||||
PhotoEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = documentationId,
|
||||
fileName = fileName,
|
||||
orderIndex = nextOrder,
|
||||
createdAt = now.toEpochMilli(),
|
||||
).also { photoDao.insert(it) }
|
||||
} catch (e: Throwable) {
|
||||
// DB-Eintrag fehlgeschlagen (z. B. Datenbank voll): die gerade importierte Datei
|
||||
// wäre sonst eine verwaiste Datei ohne Referenz.
|
||||
runCatching { photoStorage.delete(documentationId, fileName) }
|
||||
throw e
|
||||
}
|
||||
return Photo(entity.id, entity.documentationId, entity.fileName, entity.orderIndex, now)
|
||||
}
|
||||
|
||||
@@ -284,10 +301,22 @@ class DocumentationRepository(
|
||||
* verwendet) und delegiert die eigentliche Erzeugung an [pdfExporter].
|
||||
*/
|
||||
suspend fun exportPdf(documentationId: String): PdfExportResult {
|
||||
val documentation = getFullDocumentation(documentationId)
|
||||
?: return PdfExportResult.Failure(PdfExportError.DocumentationNotFound)
|
||||
val model = DocumentationToPdfExportModelMapper.map(documentation)
|
||||
return pdfExporter.export(model)
|
||||
return try {
|
||||
val documentation = getFullDocumentation(documentationId)
|
||||
?: return PdfExportResult.Failure(PdfExportError.DocumentationNotFound)
|
||||
val model = DocumentationToPdfExportModelMapper.map(documentation)
|
||||
pdfExporter.export(model)
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Throwable) {
|
||||
// Vertrag: der Export wirft nie - weder bei Datenbankfehlern noch bei Speichermangel.
|
||||
// Technische Fehlertexte werden bewusst nicht weitergereicht (Datenschutz).
|
||||
when (FailureCategory.of(e)) {
|
||||
FailureCategory.OUT_OF_MEMORY -> PdfExportResult.Failure(PdfExportError.OutOfMemory)
|
||||
FailureCategory.OUT_OF_STORAGE -> PdfExportResult.Failure(PdfExportError.InsufficientStorage)
|
||||
FailureCategory.OTHER -> PdfExportResult.Failure(PdfExportError.Unexpected(e::class.java.simpleName))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -298,7 +327,17 @@ class DocumentationRepository(
|
||||
* erneutes Laden wäre unnötige Doppelarbeit.
|
||||
*/
|
||||
suspend fun convertPdfToImages(documentationId: String, pdfFile: File): PdfToImagesResult =
|
||||
pdfToImagesConverter.convert(documentationId, pdfFile)
|
||||
try {
|
||||
pdfToImagesConverter.convert(documentationId, pdfFile)
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Throwable) {
|
||||
when (FailureCategory.of(e)) {
|
||||
FailureCategory.OUT_OF_MEMORY -> PdfToImagesResult.Failure.OutOfMemory
|
||||
FailureCategory.OUT_OF_STORAGE -> PdfToImagesResult.Failure.InsufficientStorage
|
||||
FailureCategory.OTHER -> PdfToImagesResult.Failure.Unexpected(e::class.java.simpleName)
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Liefert eine speicherschonende Vorschauversion eines Fotos für die Anzeige im Fotogitter
|
||||
@@ -352,18 +391,24 @@ class DocumentationRepository(
|
||||
require(!SignatureBitmapValidation.isBlank(bitmap)) { "Eine leere Signatur kann nicht gespeichert werden." }
|
||||
|
||||
val fileName = signatureStorage.save(documentationId, bitmap)
|
||||
val nextOrderIndex = signatureDao.getMaxOrderIndex(documentationId) + 1
|
||||
val now = Instant.now()
|
||||
val entity = SignatureEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = documentationId,
|
||||
signerName = trimmedName,
|
||||
fileName = fileName,
|
||||
orderIndex = nextOrderIndex,
|
||||
createdAt = now.toEpochMilli(),
|
||||
)
|
||||
signatureDao.insert(entity)
|
||||
woundCarerRepository.recordSignatureUsage(trimmedName, bitmap)
|
||||
val entity = try {
|
||||
SignatureEntity(
|
||||
id = UUID.randomUUID().toString(),
|
||||
documentationId = documentationId,
|
||||
signerName = trimmedName,
|
||||
fileName = fileName,
|
||||
orderIndex = signatureDao.getMaxOrderIndex(documentationId) + 1,
|
||||
createdAt = now.toEpochMilli(),
|
||||
).also { signatureDao.insert(it) }
|
||||
} catch (e: Throwable) {
|
||||
runCatching { signatureStorage.delete(documentationId, fileName) }
|
||||
throw e
|
||||
}
|
||||
// Das Wundversorger-Register ist nur eine Komfortfunktion (Namensvorschläge). Scheitert
|
||||
// es, ist die Signatur der Dokumentation trotzdem bereits sicher gespeichert - der
|
||||
// Nutzer darf dann keine Fehlermeldung bekommen, die ihn die Signatur erneut erfassen lässt.
|
||||
runCatchingCancellable { woundCarerRepository.recordSignatureUsage(trimmedName, bitmap) }
|
||||
return Signature(entity.id, entity.documentationId, entity.signerName, entity.fileName, entity.orderIndex, now)
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,59 @@
|
||||
package de.medapp.wunddoku.domain.error
|
||||
|
||||
import kotlinx.coroutines.CancellationException
|
||||
|
||||
/**
|
||||
* Grobe Einordnung eines Fehlers für die Anzeige und Weiterbehandlung.
|
||||
*
|
||||
* Bewusst rein in Kotlin/JVM gehalten (keine Android-Klassen), damit die Einordnung per
|
||||
* einfachem JVM-Unit-Test prüfbar ist. Android-spezifische Typen (z. B. `SQLiteFullException`)
|
||||
* werden deshalb über Klassenname bzw. Meldungstext erkannt.
|
||||
*/
|
||||
enum class FailureCategory {
|
||||
/** Arbeitsspeicher erschöpft ([OutOfMemoryError]). */
|
||||
OUT_OF_MEMORY,
|
||||
|
||||
/** Geräte-/Datenbankspeicher voll (ENOSPC, `SQLiteFullException`, "disk is full"). */
|
||||
OUT_OF_STORAGE,
|
||||
|
||||
/** Alles andere. */
|
||||
OTHER,
|
||||
;
|
||||
|
||||
companion object {
|
||||
private const val SQLITE_FULL_EXCEPTION = "android.database.sqlite.SQLiteFullException"
|
||||
private val STORAGE_FULL_MARKERS = listOf(
|
||||
"no space left on device",
|
||||
"enospc",
|
||||
"database or disk is full",
|
||||
"disk full",
|
||||
"sqlite_full",
|
||||
)
|
||||
|
||||
/** Durchsucht [throwable] samt gesamter Ursachenkette. */
|
||||
fun of(throwable: Throwable): FailureCategory {
|
||||
val seen = HashSet<Throwable>()
|
||||
var current: Throwable? = throwable
|
||||
while (current != null && seen.add(current)) {
|
||||
if (current is OutOfMemoryError) return OUT_OF_MEMORY
|
||||
if (current.javaClass.name == SQLITE_FULL_EXCEPTION) return OUT_OF_STORAGE
|
||||
val message = current.message?.lowercase()
|
||||
if (message != null && STORAGE_FULL_MARKERS.any { message.contains(it) }) return OUT_OF_STORAGE
|
||||
current = current.cause
|
||||
}
|
||||
return OTHER
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Wie [runCatching], reicht aber eine Coroutine-Abbruch-Exception immer weiter - ein
|
||||
* abgebrochener Vorgang darf nicht als "Fehler" verschluckt werden.
|
||||
*/
|
||||
inline fun <T> runCatchingCancellable(block: () -> T): Result<T> = try {
|
||||
Result.success(block())
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Exception) {
|
||||
Result.failure(e)
|
||||
}
|
||||
@@ -172,22 +172,37 @@ class InternalPhotoStorage(private val context: Context) : PhotoStorage {
|
||||
}.getOrDefault(ExifInterface.ORIENTATION_NORMAL)
|
||||
} ?: ExifInterface.ORIENTATION_NORMAL
|
||||
|
||||
val corrected = ImageDownsampler.applyExifOrientation(decoded, orientation)
|
||||
val corrected = try {
|
||||
ImageDownsampler.applyExifOrientation(decoded, orientation)
|
||||
} catch (e: Throwable) {
|
||||
decoded.recycle()
|
||||
throw e
|
||||
}
|
||||
|
||||
// 4) Als neue, eigenständige JPEG-Datei im dokumentationsspezifischen Verzeichnis
|
||||
// speichern. Erneutes Kodieren als JPEG verwirft dabei nebenbei die ursprünglichen
|
||||
// EXIF-Metadaten (z. B. GPS-Position) des Originalfotos, statt sie 1:1 zu
|
||||
// übernehmen - für sensible medizinische Dokumentationsfotos ein willkommener
|
||||
// Nebeneffekt, keine bewusste Anforderung dieser Aufgabe.
|
||||
// EXIF-Metadaten (z. B. GPS-Position) des Originalfotos.
|
||||
//
|
||||
// Fehlerbehandlung: Bitmap.compress() liefert bei einem Schreibfehler (z. B. Speicher
|
||||
// voll) nur `false` statt zu werfen - das wird hier zu einer Exception, und eine
|
||||
// halb geschriebene Datei wird in jedem Fehlerfall wieder entfernt, damit nie eine
|
||||
// defekte Bilddatei im Dokumentationsordner liegen bleibt.
|
||||
val targetDir = ensureDocumentationDir(documentationId)
|
||||
val fileName = "${UUID.randomUUID()}.jpg"
|
||||
File(targetDir, fileName).outputStream().use { out ->
|
||||
corrected.compress(Bitmap.CompressFormat.JPEG, ImageDownsampler.JPEG_QUALITY, out)
|
||||
val targetFile = File(targetDir, fileName)
|
||||
try {
|
||||
val written = targetFile.outputStream().use { out ->
|
||||
corrected.compress(Bitmap.CompressFormat.JPEG, ImageDownsampler.JPEG_QUALITY, out)
|
||||
}
|
||||
if (!written) throw java.io.IOException("Bild konnte nicht gespeichert werden.")
|
||||
} catch (e: Throwable) {
|
||||
targetFile.delete()
|
||||
throw e
|
||||
} finally {
|
||||
if (corrected !== decoded) decoded.recycle()
|
||||
corrected.recycle()
|
||||
}
|
||||
|
||||
if (corrected !== decoded) decoded.recycle()
|
||||
corrected.recycle()
|
||||
|
||||
fileName
|
||||
}
|
||||
|
||||
@@ -199,7 +214,13 @@ class InternalPhotoStorage(private val context: Context) : PhotoStorage {
|
||||
val sourceFile = resolve(sourceDocumentationId, sourceFileName)
|
||||
val targetFileName = "${UUID.randomUUID()}.jpg"
|
||||
val targetFile = File(ensureDocumentationDir(targetDocumentationId), targetFileName)
|
||||
sourceFile.copyTo(targetFile, overwrite = false)
|
||||
try {
|
||||
sourceFile.copyTo(targetFile, overwrite = false)
|
||||
} catch (e: Throwable) {
|
||||
// Keine halb kopierte Datei zurücklassen.
|
||||
targetFile.delete()
|
||||
throw e
|
||||
}
|
||||
targetFileName
|
||||
}
|
||||
|
||||
|
||||
@@ -7,6 +7,7 @@ import android.graphics.Paint
|
||||
import android.graphics.Typeface
|
||||
import android.graphics.pdf.PdfDocument
|
||||
import android.text.TextPaint
|
||||
import de.medapp.wunddoku.domain.error.FailureCategory
|
||||
import de.medapp.wunddoku.domain.model.InputSpecCodec
|
||||
import de.medapp.wunddoku.media.PhotoStorage
|
||||
import de.medapp.wunddoku.signature.SignatureStorage
|
||||
@@ -185,11 +186,18 @@ class AndroidPdfDocumentExporter(
|
||||
}
|
||||
|
||||
PdfExportResult.Success(targetFile)
|
||||
} catch (e: Exception) {
|
||||
} catch (e: Throwable) {
|
||||
tempFile.delete()
|
||||
PdfExportResult.Failure(
|
||||
PdfExportError.WriteFailed(e.message ?: "Unbekannter Fehler bei der PDF-Erzeugung.")
|
||||
)
|
||||
if (e is kotlinx.coroutines.CancellationException) throw e
|
||||
// Bewusst Throwable: OutOfMemoryError ist ein Error, keine Exception, und würde
|
||||
// sonst die App beenden. Eine bereits vorhandene PDF am Zielpfad bleibt unangetastet.
|
||||
when (FailureCategory.of(e)) {
|
||||
FailureCategory.OUT_OF_MEMORY -> PdfExportResult.Failure(PdfExportError.OutOfMemory)
|
||||
FailureCategory.OUT_OF_STORAGE -> PdfExportResult.Failure(PdfExportError.InsufficientStorage)
|
||||
FailureCategory.OTHER -> PdfExportResult.Failure(
|
||||
PdfExportError.WriteFailed(e.message ?: "Unbekannter Fehler bei der PDF-Erzeugung.")
|
||||
)
|
||||
}
|
||||
} finally {
|
||||
pdfDocument.close()
|
||||
// Erst JETZT sicher, da writeTo() (im try-Block oben) zu diesem Zeitpunkt entweder
|
||||
|
||||
@@ -38,4 +38,25 @@ sealed interface PdfExportError {
|
||||
data class DirectoryCreationFailed(val path: String) : PdfExportError
|
||||
data class WriteFailed(val message: String) : PdfExportError
|
||||
data class Unexpected(val message: String) : PdfExportError
|
||||
|
||||
/** Arbeitsspeicher reichte für die PDF-Erzeugung nicht aus (z. B. sehr viele Fotos). */
|
||||
data object OutOfMemory : PdfExportError
|
||||
|
||||
/** Auf dem Gerät ist nicht genug freier Speicherplatz für die PDF-Datei vorhanden. */
|
||||
data object InsufficientStorage : PdfExportError
|
||||
}
|
||||
|
||||
/**
|
||||
* Verständliche Anzeige-Meldung ohne technische Details (keine Pfade, keine Exception-Texte -
|
||||
* Datenschutz: es können Patientendaten im Dateinamen/Pfad stecken).
|
||||
*/
|
||||
fun PdfExportError.toUserMessage(): String = when (this) {
|
||||
PdfExportError.DocumentationNotFound -> "Die Dokumentation wurde nicht gefunden."
|
||||
is PdfExportError.DirectoryCreationFailed -> "Zielverzeichnis konnte nicht angelegt werden."
|
||||
is PdfExportError.WriteFailed -> "Beim Schreiben der PDF-Datei ist ein Fehler aufgetreten."
|
||||
is PdfExportError.Unexpected -> "Es ist ein unerwarteter Fehler aufgetreten."
|
||||
PdfExportError.OutOfMemory ->
|
||||
"Nicht genügend Arbeitsspeicher. Bitte andere Apps schließen oder weniger Fotos verwenden."
|
||||
PdfExportError.InsufficientStorage ->
|
||||
"Nicht genügend freier Speicherplatz auf dem Gerät."
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@ import android.graphics.Bitmap
|
||||
import android.graphics.Color
|
||||
import android.graphics.pdf.PdfRenderer
|
||||
import android.os.ParcelFileDescriptor
|
||||
import de.medapp.wunddoku.domain.error.FailureCategory
|
||||
import kotlinx.coroutines.Dispatchers
|
||||
import kotlinx.coroutines.withContext
|
||||
import java.io.File
|
||||
@@ -41,6 +42,12 @@ sealed interface PdfToImagesResult {
|
||||
data object EmptyDocument : Failure
|
||||
|
||||
data class Unexpected(val message: String) : Failure
|
||||
|
||||
/** Arbeitsspeicher reichte zum Rendern der Seiten nicht aus. */
|
||||
data object OutOfMemory : Failure
|
||||
|
||||
/** Nicht genug freier Speicherplatz für die Bilddateien. */
|
||||
data object InsufficientStorage : Failure
|
||||
}
|
||||
}
|
||||
|
||||
@@ -51,6 +58,10 @@ fun PdfToImagesResult.Failure.toUserMessage(): String = when (this) {
|
||||
"Die PDF-Datei enthält keine Seiten."
|
||||
is PdfToImagesResult.Failure.Unexpected ->
|
||||
"Die PDF-Datei konnte nicht in Bilder umgewandelt werden."
|
||||
PdfToImagesResult.Failure.OutOfMemory ->
|
||||
"Nicht genügend Arbeitsspeicher zum Umwandeln in Bilder."
|
||||
PdfToImagesResult.Failure.InsufficientStorage ->
|
||||
"Nicht genügend freier Speicherplatz für die Bilder."
|
||||
}
|
||||
|
||||
class AndroidPdfToImagesConverter(private val context: Context) : PdfToImagesConverter {
|
||||
@@ -102,8 +113,17 @@ class AndroidPdfToImagesConverter(private val context: Context) : PdfToImagesCon
|
||||
PdfToImagesResult.Success(imageFiles)
|
||||
}
|
||||
}
|
||||
} catch (e: Exception) {
|
||||
PdfToImagesResult.Failure.Unexpected(e.message ?: "Unbekannter Fehler bei der Bildkonvertierung.")
|
||||
} catch (e: Throwable) {
|
||||
// Abbruch der Coroutine nie verschlucken.
|
||||
if (e is kotlinx.coroutines.CancellationException) throw e
|
||||
// Halbfertigen Bildsatz entfernen: ein unvollständiger Satz darf nie geteilt werden.
|
||||
outputDir.deleteRecursively()
|
||||
when (FailureCategory.of(e)) {
|
||||
FailureCategory.OUT_OF_MEMORY -> PdfToImagesResult.Failure.OutOfMemory
|
||||
FailureCategory.OUT_OF_STORAGE -> PdfToImagesResult.Failure.InsufficientStorage
|
||||
FailureCategory.OTHER ->
|
||||
PdfToImagesResult.Failure.Unexpected(e.message ?: "Unbekannter Fehler bei der Bildkonvertierung.")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -104,11 +104,20 @@ class InternalSignatureStorage(
|
||||
withContext(Dispatchers.IO) {
|
||||
val fileName = "${UUID.randomUUID()}.png"
|
||||
val targetDir = ensureDocumentationDir(documentationId)
|
||||
FileOutputStream(File(targetDir, fileName)).use { out ->
|
||||
// Qualität 100 ist bei PNG (verlustfreies Format) bedeutungslos - wird trotzdem
|
||||
// explizit angegeben, da Bitmap.compress() den Parameter unabhängig vom Format
|
||||
// verlangt.
|
||||
bitmap.compress(Bitmap.CompressFormat.PNG, 100, out)
|
||||
val targetFile = File(targetDir, fileName)
|
||||
try {
|
||||
val written = FileOutputStream(targetFile).use { out ->
|
||||
// Qualität 100 ist bei PNG (verlustfreies Format) bedeutungslos - wird trotzdem
|
||||
// explizit angegeben, da Bitmap.compress() den Parameter unabhängig vom Format
|
||||
// verlangt.
|
||||
bitmap.compress(Bitmap.CompressFormat.PNG, 100, out)
|
||||
}
|
||||
// compress() meldet Schreibfehler (z. B. Speicher voll) nur über `false`.
|
||||
if (!written) throw java.io.IOException("Signatur konnte nicht gespeichert werden.")
|
||||
} catch (e: Throwable) {
|
||||
// Keine leere/halbe PNG-Datei als scheinbar gültige Signatur zurücklassen.
|
||||
targetFile.delete()
|
||||
throw e
|
||||
}
|
||||
fileName
|
||||
}
|
||||
|
||||
@@ -252,6 +252,13 @@ fun DocumentationEditScreen(
|
||||
snackbarHostState.showSnackbar(message)
|
||||
viewModel.dismissShareMessage()
|
||||
}
|
||||
// Speicherfehler beim Autosave/Löschen: der Nutzer muss erfahren, dass eine Änderung NICHT
|
||||
// gespeichert wurde (sonst entsteht unbemerkter Datenverlust).
|
||||
LaunchedEffect(uiState.saveError) {
|
||||
val message = uiState.saveError ?: return@LaunchedEffect
|
||||
snackbarHostState.showSnackbar(message)
|
||||
viewModel.dismissSaveError()
|
||||
}
|
||||
|
||||
Scaffold(
|
||||
snackbarHost = { SnackbarHost(snackbarHostState) },
|
||||
|
||||
+97
-20
@@ -11,13 +11,15 @@ import androidx.navigation.toRoute
|
||||
import de.medapp.wunddoku.data.repository.DocumentationRepository
|
||||
import de.medapp.wunddoku.data.repository.WoundCarerRepository
|
||||
import de.medapp.wunddoku.di.wunddokuApplication
|
||||
import de.medapp.wunddoku.domain.error.FailureCategory
|
||||
import de.medapp.wunddoku.domain.error.runCatchingCancellable
|
||||
import de.medapp.wunddoku.domain.model.Documentation
|
||||
import de.medapp.wunddoku.domain.model.WoundCarer
|
||||
import de.medapp.wunddoku.pdf.PdfExportError
|
||||
import de.medapp.wunddoku.pdf.PdfExportResult
|
||||
import de.medapp.wunddoku.pdf.PdfToImagesResult
|
||||
import de.medapp.wunddoku.pdf.toUserMessage
|
||||
import de.medapp.wunddoku.ui.navigation.Screen
|
||||
import kotlinx.coroutines.CancellationException
|
||||
import kotlinx.coroutines.FlowPreview
|
||||
import kotlinx.coroutines.flow.MutableSharedFlow
|
||||
import kotlinx.coroutines.flow.MutableStateFlow
|
||||
@@ -90,6 +92,10 @@ data class DocumentationEditUiState(
|
||||
/** Analog [imagesToShare], nur für die Variante "als PDF teilen" - Gegenstück
|
||||
* [DocumentationEditViewModel.onPdfShareHandled]. */
|
||||
val pdfToShare: File? = null,
|
||||
/** Einmalige Fehlermeldung, wenn eine Änderung (Haken, Freitext, Löschen) NICHT in der
|
||||
* Datenbank gespeichert werden konnte - z. B. bei vollem Speicher. Die Anzeige zeigt dann
|
||||
* wieder den tatsächlich gespeicherten Stand, nie einen nur scheinbar gespeicherten. */
|
||||
val saveError: String? = null,
|
||||
) {
|
||||
val blockCount: Int get() = documentation?.blocks?.size ?: 0
|
||||
|
||||
@@ -140,7 +146,14 @@ class DocumentationEditViewModel(
|
||||
|
||||
private suspend fun loadDocumentation() {
|
||||
_uiState.update { it.copy(isLoading = true, error = null) }
|
||||
val documentation = repository.getFullDocumentation(documentationId)
|
||||
val documentation = try {
|
||||
repository.getFullDocumentation(documentationId)
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Exception) {
|
||||
_uiState.update { it.copy(isLoading = false, error = "Dokumentation konnte nicht geladen werden.") }
|
||||
return
|
||||
}
|
||||
_uiState.update {
|
||||
if (documentation != null) {
|
||||
it.copy(documentation = documentation, isLoading = false)
|
||||
@@ -160,11 +173,48 @@ class DocumentationEditViewModel(
|
||||
}
|
||||
|
||||
private suspend fun persistFreeText(checkItemStateId: String, text: String) {
|
||||
repository.updateFreeText(checkItemStateId, text)
|
||||
// Fehler (z. B. voller Speicher) dürfen weder die Debounce-Schleife beenden noch die App
|
||||
// abstürzen lassen. Der Wert bleibt in [pendingFreeText] und wird beim nächsten Flush
|
||||
// (ON_STOP) bzw. bei der nächsten Eingabe erneut geschrieben - kein stiller Datenverlust.
|
||||
val result = runCatchingCancellable { repository.updateFreeText(checkItemStateId, text) }
|
||||
if (result.isFailure) {
|
||||
reportSaveFailure(result.exceptionOrNull())
|
||||
return
|
||||
}
|
||||
// Nur entfernen, wenn zwischenzeitlich kein neuerer Wert eingetroffen ist.
|
||||
if (pendingFreeText[checkItemStateId] == text) pendingFreeText.remove(checkItemStateId)
|
||||
}
|
||||
|
||||
private fun reportSaveFailure(cause: Throwable?, fallback: String = "Die Änderung konnte nicht gespeichert werden.") {
|
||||
val message = when (cause?.let { FailureCategory.of(it) }) {
|
||||
FailureCategory.OUT_OF_STORAGE -> "Nicht genügend Speicherplatz - die Änderung konnte nicht gespeichert werden."
|
||||
FailureCategory.OUT_OF_MEMORY -> "Nicht genügend Arbeitsspeicher - die Änderung konnte nicht gespeichert werden."
|
||||
else -> fallback
|
||||
}
|
||||
_uiState.update { it.copy(saveError = message) }
|
||||
}
|
||||
|
||||
/** Lädt den tatsächlich gespeicherten Stand neu (best effort), z. B. nach einem
|
||||
* fehlgeschlagenen Schreibvorgang, damit die Anzeige nie vom Datenbankstand abweicht. */
|
||||
private suspend fun refreshFromDatabase() {
|
||||
val refreshed = runCatchingCancellable { repository.getFullDocumentation(documentationId) }.getOrNull()
|
||||
if (refreshed != null) {
|
||||
// Noch nicht gespeicherte Freitexte (pendingFreeText) bleiben in der Anzeige erhalten.
|
||||
val merged = if (pendingFreeText.isEmpty()) refreshed else refreshed.copy(
|
||||
blocks = refreshed.blocks.map { block ->
|
||||
block.copy(items = block.items.map { item ->
|
||||
pendingFreeText[item.checkItemStateId]?.let { item.copy(freeTextValue = it) } ?: item
|
||||
})
|
||||
},
|
||||
)
|
||||
_uiState.update { it.copy(documentation = merged) }
|
||||
}
|
||||
}
|
||||
|
||||
fun dismissSaveError() {
|
||||
_uiState.update { it.copy(saveError = null) }
|
||||
}
|
||||
|
||||
/**
|
||||
* [checkItemStateId] referenziert die Freitext-Option eines Blocks (CheckItem.isFreeText =
|
||||
* true), NICHT den Block selbst - der Freitext ist seit der Umstellung auf eine
|
||||
@@ -202,7 +252,13 @@ class DocumentationEditViewModel(
|
||||
state.copy(documentation = documentation.copy(blocks = updatedBlocks))
|
||||
}
|
||||
// 2) sofort persistieren (kein Debounce nötig, einzelnes günstiges UPDATE)
|
||||
viewModelScope.launch { repository.setChecked(checkItemStateId, checked) }
|
||||
viewModelScope.launch {
|
||||
val result = runCatchingCancellable { repository.setChecked(checkItemStateId, checked) }
|
||||
if (result.isFailure) {
|
||||
reportSaveFailure(result.exceptionOrNull())
|
||||
refreshFromDatabase()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -261,11 +317,20 @@ class DocumentationEditViewModel(
|
||||
try {
|
||||
photoImportMutex.withLock {
|
||||
var failureCount = 0
|
||||
var outOfMemoryCount = 0
|
||||
var outOfStorageCount = 0
|
||||
for (uri in uris) {
|
||||
try {
|
||||
repository.addPhoto(documentationId, uri)
|
||||
} catch (e: Exception) {
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Throwable) {
|
||||
// Throwable (statt Exception): OutOfMemoryError beim Dekodieren großer
|
||||
// Fotos darf die App nicht beenden - das Bild gilt als fehlgeschlagen,
|
||||
// die übrigen Bilder werden weiter importiert.
|
||||
failureCount++
|
||||
if (FailureCategory.of(e) == FailureCategory.OUT_OF_MEMORY) outOfMemoryCount++
|
||||
if (FailureCategory.of(e) == FailureCategory.OUT_OF_STORAGE) outOfStorageCount++
|
||||
// Bewusst OHNE Uri/Dateipfad geloggt (Datenschutz-Vorgabe: keine Bild-Uris/
|
||||
// Dateipfade in Logs) - die Exception-Nachricht selbst genügt zur Diagnose.
|
||||
android.util.Log.w(
|
||||
@@ -274,12 +339,17 @@ class DocumentationEditViewModel(
|
||||
)
|
||||
}
|
||||
}
|
||||
val refreshed = repository.getFullDocumentation(documentationId)
|
||||
val refreshed = runCatchingCancellable { repository.getFullDocumentation(documentationId) }.getOrNull()
|
||||
val reason = when {
|
||||
outOfStorageCount > 0 -> " Nicht genügend Speicherplatz."
|
||||
outOfMemoryCount > 0 -> " Nicht genügend Arbeitsspeicher."
|
||||
else -> ""
|
||||
}
|
||||
_uiState.update { state ->
|
||||
state.copy(
|
||||
documentation = refreshed ?: state.documentation,
|
||||
photoImportError = if (failureCount > 0) {
|
||||
"$failureCount von ${uris.size} Bild(ern) konnten nicht importiert werden."
|
||||
"$failureCount von ${uris.size} Bild(ern) konnten nicht importiert werden.$reason"
|
||||
} else {
|
||||
state.photoImportError
|
||||
},
|
||||
@@ -317,8 +387,9 @@ class DocumentationEditViewModel(
|
||||
fun confirmDeletePhoto() {
|
||||
val photoId = _uiState.value.pendingDeletePhotoId ?: return
|
||||
viewModelScope.launch {
|
||||
repository.removePhoto(photoId)
|
||||
val refreshed = repository.getFullDocumentation(documentationId)
|
||||
val result = runCatchingCancellable { repository.removePhoto(photoId) }
|
||||
if (result.isFailure) reportSaveFailure(result.exceptionOrNull(), "Das Foto konnte nicht gelöscht werden.")
|
||||
val refreshed = runCatchingCancellable { repository.getFullDocumentation(documentationId) }.getOrNull()
|
||||
_uiState.update { state ->
|
||||
state.copy(
|
||||
documentation = refreshed ?: state.documentation,
|
||||
@@ -358,6 +429,17 @@ class DocumentationEditViewModel(
|
||||
}
|
||||
} catch (e: IllegalArgumentException) {
|
||||
_uiState.update { it.copy(signatureError = e.message ?: "Signatur konnte nicht gespeichert werden.") }
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Throwable) {
|
||||
// Speicherfehler o. Ä.: Dialog bleibt offen, die gezeichnete Signatur geht nicht
|
||||
// verloren und kann nach Freigabe von Speicher erneut gespeichert werden.
|
||||
val message = when (FailureCategory.of(e)) {
|
||||
FailureCategory.OUT_OF_STORAGE -> "Nicht genügend Speicherplatz - die Signatur konnte nicht gespeichert werden."
|
||||
FailureCategory.OUT_OF_MEMORY -> "Nicht genügend Arbeitsspeicher - die Signatur konnte nicht gespeichert werden."
|
||||
FailureCategory.OTHER -> "Die Signatur konnte nicht gespeichert werden."
|
||||
}
|
||||
_uiState.update { it.copy(signatureError = message) }
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -379,8 +461,9 @@ class DocumentationEditViewModel(
|
||||
fun confirmDeleteSignature() {
|
||||
val signatureId = _uiState.value.pendingDeleteSignatureId ?: return
|
||||
viewModelScope.launch {
|
||||
repository.removeSignature(signatureId)
|
||||
val refreshed = repository.getFullDocumentation(documentationId)
|
||||
val result = runCatchingCancellable { repository.removeSignature(signatureId) }
|
||||
if (result.isFailure) reportSaveFailure(result.exceptionOrNull(), "Die Signatur konnte nicht gelöscht werden.")
|
||||
val refreshed = runCatchingCancellable { repository.getFullDocumentation(documentationId) }.getOrNull()
|
||||
_uiState.update { state ->
|
||||
state.copy(
|
||||
documentation = refreshed ?: state.documentation,
|
||||
@@ -539,13 +622,6 @@ class DocumentationEditViewModel(
|
||||
_uiState.update { it.copy(shareMessage = null) }
|
||||
}
|
||||
|
||||
private fun PdfExportError.toUserMessage(): String = when (this) {
|
||||
PdfExportError.DocumentationNotFound -> "Die Dokumentation wurde nicht gefunden."
|
||||
is PdfExportError.DirectoryCreationFailed -> "Zielverzeichnis konnte nicht angelegt werden."
|
||||
is PdfExportError.WriteFailed -> "Beim Schreiben der PDF-Datei ist ein Fehler aufgetreten."
|
||||
is PdfExportError.Unexpected -> "Es ist ein unerwarteter Fehler aufgetreten."
|
||||
}
|
||||
|
||||
/**
|
||||
* Lädt eine speicherschonende Vorschauversion eines Fotos für die Anzeige im Fotogitter.
|
||||
* Bewusst NICHT im zentralen UiState gehalten (kein `Bitmap`-Feld in
|
||||
@@ -589,9 +665,10 @@ class DocumentationEditViewModel(
|
||||
fun flushPendingChanges() {
|
||||
if (pendingFreeText.isEmpty()) return
|
||||
val toFlush = pendingFreeText.toMap()
|
||||
pendingFreeText.clear()
|
||||
viewModelScope.launch {
|
||||
toFlush.forEach { (checkItemStateId, text) -> repository.updateFreeText(checkItemStateId, text) }
|
||||
// Einträge werden erst NACH erfolgreichem Schreiben aus pendingFreeText entfernt -
|
||||
// scheitert das Schreiben, bleibt der Text für den nächsten Versuch erhalten.
|
||||
toFlush.forEach { (checkItemStateId, text) -> persistFreeText(checkItemStateId, text) }
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -9,6 +9,7 @@ import androidx.navigation.toRoute
|
||||
import de.medapp.wunddoku.data.repository.DocumentationRepository
|
||||
import de.medapp.wunddoku.data.repository.PatientRepository
|
||||
import de.medapp.wunddoku.di.wunddokuApplication
|
||||
import de.medapp.wunddoku.domain.error.FailureCategory
|
||||
import de.medapp.wunddoku.domain.model.Patient
|
||||
import de.medapp.wunddoku.domain.model.PatientListItem
|
||||
import de.medapp.wunddoku.ui.components.format.DATE_MAX_DIGITS
|
||||
@@ -18,6 +19,7 @@ import de.medapp.wunddoku.ui.components.format.filterDigits
|
||||
import de.medapp.wunddoku.ui.components.format.germanDateDigitsToLocalDateOrNull
|
||||
import de.medapp.wunddoku.ui.components.format.toGermanDateDigits
|
||||
import de.medapp.wunddoku.ui.navigation.Screen
|
||||
import kotlinx.coroutines.CancellationException
|
||||
import kotlinx.coroutines.ExperimentalCoroutinesApi
|
||||
import kotlinx.coroutines.flow.MutableStateFlow
|
||||
import kotlinx.coroutines.flow.StateFlow
|
||||
@@ -187,7 +189,7 @@ class PatientFormViewModel(
|
||||
fun useExistingPatient() {
|
||||
val existing = _uiState.value.duplicateWarning ?: return
|
||||
_uiState.update { it.copy(duplicateWarning = null) }
|
||||
viewModelScope.launch { finish(existing.id) }
|
||||
viewModelScope.launch { guardedFinish(existing.id) }
|
||||
}
|
||||
|
||||
/** Der Nutzer entscheidet sich im Duplikat-Dialog, trotzdem einen neuen Patienten anzulegen. */
|
||||
@@ -241,12 +243,39 @@ class PatientFormViewModel(
|
||||
createdAt = Instant.EPOCH, // wird von PatientRepository.upsert() korrekt gesetzt
|
||||
updatedAt = Instant.EPOCH,
|
||||
)
|
||||
val saved = repository.upsert(patient)
|
||||
val saved = try {
|
||||
repository.upsert(patient)
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Exception) {
|
||||
reportPersistenceFailure(e, "Der Patient konnte nicht gespeichert werden.")
|
||||
return@launch
|
||||
}
|
||||
_uiState.update { it.copy(validationError = null) }
|
||||
finish(saved.id)
|
||||
guardedFinish(saved.id)
|
||||
}
|
||||
}
|
||||
|
||||
/** Wie [finish], fängt aber Datenbankfehler (z. B. voller Speicher) ab: Das Formular bleibt
|
||||
* mit allen Eingaben offen und zeigt eine Meldung, statt dass die App abstürzt. */
|
||||
private suspend fun guardedFinish(resolvedPatientId: String) {
|
||||
try {
|
||||
finish(resolvedPatientId)
|
||||
} catch (e: CancellationException) {
|
||||
throw e
|
||||
} catch (e: Exception) {
|
||||
reportPersistenceFailure(e, "Die Dokumentation konnte nicht angelegt werden.")
|
||||
}
|
||||
}
|
||||
|
||||
private fun reportPersistenceFailure(cause: Throwable, fallback: String) {
|
||||
val message = when (FailureCategory.of(cause)) {
|
||||
FailureCategory.OUT_OF_STORAGE -> "Nicht genügend Speicherplatz - bitte Speicher freigeben und erneut versuchen."
|
||||
else -> fallback
|
||||
}
|
||||
_uiState.update { it.copy(validationError = message) }
|
||||
}
|
||||
|
||||
/**
|
||||
* Gemeinsamer Abschluss für beide Wege, an einen gültigen Patienten zu kommen (neu
|
||||
* gespeichert oder als Duplikat übernommen): Je nach [startsNewDocumentation] entweder eine
|
||||
|
||||
@@ -0,0 +1,91 @@
|
||||
package de.medapp.wunddoku.domain.error
|
||||
|
||||
import kotlinx.coroutines.CancellationException
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Assert.fail
|
||||
import org.junit.Test
|
||||
import java.io.FileNotFoundException
|
||||
import java.io.IOException
|
||||
|
||||
/**
|
||||
* Reine JVM-Tests für die Fehlereinordnung (Speichermangel erkennen) und
|
||||
* [runCatchingCancellable].
|
||||
*/
|
||||
class FailureCategoryTest {
|
||||
|
||||
// --- Arbeitsspeicher -----------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun out_of_memory_error_wird_erkannt() {
|
||||
assertEquals(FailureCategory.OUT_OF_MEMORY, FailureCategory.of(OutOfMemoryError("Failed to allocate")))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun out_of_memory_error_wird_auch_als_ursache_erkannt() {
|
||||
val wrapped = RuntimeException("Export fehlgeschlagen", OutOfMemoryError())
|
||||
assertEquals(FailureCategory.OUT_OF_MEMORY, FailureCategory.of(wrapped))
|
||||
}
|
||||
|
||||
// --- Speicherplatz -------------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun enospc_ioexception_wird_als_speicher_voll_erkannt() {
|
||||
val e = IOException("write failed: ENOSPC (No space left on device)")
|
||||
assertEquals(FailureCategory.OUT_OF_STORAGE, FailureCategory.of(e))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun sqlite_disk_full_meldung_wird_als_speicher_voll_erkannt() {
|
||||
val e = RuntimeException("database or disk is full (code 13 SQLITE_FULL)")
|
||||
assertEquals(FailureCategory.OUT_OF_STORAGE, FailureCategory.of(e))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun erkennung_ist_unabhaengig_von_gross_und_kleinschreibung() {
|
||||
assertEquals(FailureCategory.OUT_OF_STORAGE, FailureCategory.of(IOException("NO SPACE LEFT ON DEVICE")))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speicher_voll_in_tiefer_ursachenkette_wird_erkannt() {
|
||||
val root = IOException("No space left on device")
|
||||
val chain = IllegalStateException("a", RuntimeException("b", RuntimeException("c", root)))
|
||||
assertEquals(FailureCategory.OUT_OF_STORAGE, FailureCategory.of(chain))
|
||||
}
|
||||
|
||||
// --- Sonstige Fehler -----------------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun gewoehnliche_fehler_sind_other() {
|
||||
assertEquals(FailureCategory.OTHER, FailureCategory.of(FileNotFoundException("weg")))
|
||||
assertEquals(FailureCategory.OTHER, FailureCategory.of(IllegalStateException()))
|
||||
assertEquals(FailureCategory.OTHER, FailureCategory.of(RuntimeException(null as String?)))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun zyklische_ursachenkette_fuehrt_nicht_zur_endlosschleife() {
|
||||
val a = RuntimeException("a")
|
||||
val b = RuntimeException("b", a)
|
||||
a.initCause(b)
|
||||
assertEquals(FailureCategory.OTHER, FailureCategory.of(a))
|
||||
}
|
||||
|
||||
// --- runCatchingCancellable ----------------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun runCatchingCancellable_liefert_erfolg_und_fehler_als_result() {
|
||||
assertEquals(42, runCatchingCancellable { 42 }.getOrNull())
|
||||
val failure = runCatchingCancellable<Int> { throw IOException("x") }
|
||||
assertTrue(failure.exceptionOrNull() is IOException)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun runCatchingCancellable_reicht_coroutine_abbruch_weiter() {
|
||||
try {
|
||||
runCatchingCancellable<Unit> { throw CancellationException("abgebrochen") }
|
||||
fail("CancellationException darf nicht verschluckt werden")
|
||||
} catch (expected: CancellationException) {
|
||||
assertEquals("abgebrochen", expected.message)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,80 @@
|
||||
package de.medapp.wunddoku.media
|
||||
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
|
||||
/**
|
||||
* Reine JVM-Tests für [ImageDownsampler.computeInSampleSize] - der Kern der speicherschonenden
|
||||
* Bilddekodierung (Schutz vor OutOfMemoryError bei großen Kamerafotos) und der Robustheit
|
||||
* gegenüber ungültigen Abmessungen defekter Bilddateien.
|
||||
*/
|
||||
class ImageDownsamplerTest {
|
||||
|
||||
private val target = ImageDownsampler.MAX_STORED_DIMENSION_PX
|
||||
|
||||
// --- ungültige / defekte Abmessungen -------------------------------------------------
|
||||
|
||||
@Test
|
||||
fun ungueltige_abmessungen_defekter_bilder_liefern_1_statt_zu_werfen() {
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(0, 0, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(-1, -1, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(4000, 0, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(0, 4000, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(4000, 3000, 0))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(4000, 3000, -5))
|
||||
}
|
||||
|
||||
// --- Bilder, die nicht verkleinert werden müssen -------------------------------------
|
||||
|
||||
@Test
|
||||
fun kleine_bilder_werden_nicht_heruntergerechnet() {
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(100, 100, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(target, target, target))
|
||||
assertEquals(1, ImageDownsampler.computeInSampleSize(1, 1, target))
|
||||
}
|
||||
|
||||
// --- Große Bilder (Speichermangel vermeiden) -----------------------------------------
|
||||
|
||||
@Test
|
||||
fun grosse_kamerafotos_werden_deutlich_heruntergerechnet() {
|
||||
// 48 MP ≈ 8000 x 6000
|
||||
val sample = ImageDownsampler.computeInSampleSize(8000, 6000, target)
|
||||
assertTrue("erwartet >= 2, war $sample", sample >= 2)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun ergebnis_ist_immer_eine_zweierpotenz_und_haelt_die_zielgroesse_ein() {
|
||||
val sizes = listOf(1, 2, 99, 100, 1999, 2000, 2001, 3999, 4000, 4001, 6000, 8000, 12000, 20000, 65535)
|
||||
for (width in sizes) {
|
||||
for (height in sizes) {
|
||||
val sample = ImageDownsampler.computeInSampleSize(width, height, target)
|
||||
val largest = maxOf(width, height)
|
||||
|
||||
assertTrue("Zweierpotenz erwartet bei ${width}x$height, war $sample", sample >= 1 && sample and (sample - 1) == 0)
|
||||
if (largest > target) {
|
||||
// Nie unter die Zielgröße dekodieren ...
|
||||
assertTrue("${width}x$height: dekodiert wäre ${largest / sample}", largest / sample >= target)
|
||||
// ... aber auch nie mehr als doppelt so groß wie nötig (kein Speicher-Verschwenden).
|
||||
assertTrue("${width}x$height: dekodiert wäre ${largest / sample}", largest / sample < 2 * target)
|
||||
} else {
|
||||
assertEquals(1, sample)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun extrem_grosse_werte_laufen_nicht_ueber() {
|
||||
val sample = ImageDownsampler.computeInSampleSize(Int.MAX_VALUE, Int.MAX_VALUE, target)
|
||||
assertTrue(sample >= 1)
|
||||
assertTrue(sample and (sample - 1) == 0)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun thumbnail_ziel_ist_kleiner_als_speicherziel() {
|
||||
val full = ImageDownsampler.computeInSampleSize(2000, 1500, target)
|
||||
val thumb = ImageDownsampler.computeInSampleSize(2000, 1500, ImageDownsampler.THUMBNAIL_MAX_DIMENSION_PX)
|
||||
assertTrue(thumb > full)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,106 @@
|
||||
package de.medapp.wunddoku.pdf
|
||||
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertNotEquals
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
|
||||
/**
|
||||
* Reine JVM-Tests für die Fehlermeldungen des PDF-Bereichs: jede Fehlerart hat eine
|
||||
* verständliche deutsche Meldung, und technische Details (Pfade, Exception-Texte - können
|
||||
* Patientennamen enthalten) gelangen nie in die Anzeige.
|
||||
*/
|
||||
class ErrorMessagesTest {
|
||||
|
||||
private val sensitive = "/data/user/0/de.medapp.wunddoku/files/pdf/2026-08-19_Max_Mustermann_1980-03-14.pdf"
|
||||
|
||||
private val exportErrors: List<PdfExportError> = listOf(
|
||||
PdfExportError.DocumentationNotFound,
|
||||
PdfExportError.DirectoryCreationFailed(sensitive),
|
||||
PdfExportError.WriteFailed(sensitive),
|
||||
PdfExportError.Unexpected(sensitive),
|
||||
PdfExportError.OutOfMemory,
|
||||
PdfExportError.InsufficientStorage,
|
||||
)
|
||||
|
||||
private val openFailures: List<PdfOpenResult.Failure> = listOf(
|
||||
PdfOpenResult.Failure.FileNotFound,
|
||||
PdfOpenResult.Failure.UriResolutionFailed(sensitive),
|
||||
PdfOpenResult.Failure.NoViewerAvailable,
|
||||
PdfOpenResult.Failure.Unexpected(sensitive),
|
||||
)
|
||||
|
||||
private val shareFailures: List<PdfShareResult.Failure> = listOf(
|
||||
PdfShareResult.Failure.UriResolutionFailed(sensitive),
|
||||
PdfShareResult.Failure.NoAppAvailable,
|
||||
PdfShareResult.Failure.Unexpected(sensitive),
|
||||
)
|
||||
|
||||
private val imageShareFailures: List<PdfImageShareResult.Failure> = listOf(
|
||||
PdfImageShareResult.Failure.NoImages,
|
||||
PdfImageShareResult.Failure.UriResolutionFailed(sensitive),
|
||||
PdfImageShareResult.Failure.NoAppAvailable,
|
||||
PdfImageShareResult.Failure.Unexpected(sensitive),
|
||||
)
|
||||
|
||||
private val imageConversionFailures: List<PdfToImagesResult.Failure> = listOf(
|
||||
PdfToImagesResult.Failure.FileNotFound,
|
||||
PdfToImagesResult.Failure.EmptyDocument,
|
||||
PdfToImagesResult.Failure.Unexpected(sensitive),
|
||||
PdfToImagesResult.Failure.OutOfMemory,
|
||||
PdfToImagesResult.Failure.InsufficientStorage,
|
||||
)
|
||||
|
||||
private fun assertSafe(message: String) {
|
||||
assertTrue("Meldung darf nicht leer sein", message.isNotBlank())
|
||||
assertFalse("Meldung enthält Pfad/Patientendaten: $message", message.contains("Mustermann"))
|
||||
assertFalse("Meldung enthält Pfad: $message", message.contains("/data/"))
|
||||
assertFalse("Meldung enthält Dateiendung/Pfad: $message", message.contains(".pdf"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun alle_pdf_export_fehler_haben_eine_sichere_meldung() {
|
||||
exportErrors.forEach { assertSafe(it.toUserMessage()) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun alle_oeffnen_fehler_haben_eine_sichere_meldung() {
|
||||
openFailures.forEach { assertSafe(it.toUserMessage()) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun alle_pdf_teilen_fehler_haben_eine_sichere_meldung() {
|
||||
shareFailures.forEach { assertSafe(it.toUserMessage()) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun alle_bilder_teilen_fehler_haben_eine_sichere_meldung() {
|
||||
imageShareFailures.forEach { assertSafe(it.toUserMessage()) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun alle_bildkonvertierungs_fehler_haben_eine_sichere_meldung() {
|
||||
imageConversionFailures.forEach { assertSafe(it.toUserMessage()) }
|
||||
}
|
||||
|
||||
@Test
|
||||
fun speichermangel_hat_eine_eigene_aussagekraeftige_meldung() {
|
||||
assertNotEquals(PdfExportError.OutOfMemory.toUserMessage(), PdfExportError.InsufficientStorage.toUserMessage())
|
||||
assertNotEquals(
|
||||
PdfExportError.OutOfMemory.toUserMessage(),
|
||||
PdfExportError.Unexpected("x").toUserMessage(),
|
||||
)
|
||||
assertNotEquals(
|
||||
PdfToImagesResult.Failure.OutOfMemory.toUserMessage(),
|
||||
PdfToImagesResult.Failure.InsufficientStorage.toUserMessage(),
|
||||
)
|
||||
assertTrue(PdfExportError.InsufficientStorage.toUserMessage().contains("Speicher"))
|
||||
assertTrue(PdfExportError.OutOfMemory.toUserMessage().contains("Arbeitsspeicher"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun unterschiedliche_fehlerarten_erhalten_unterschiedliche_meldungen() {
|
||||
val messages = exportErrors.map { it.toUserMessage() }
|
||||
assertTrue(messages.toSet().size == messages.size)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user